webrtc/modules/audio_processing/echo_cancellation_impl.h - Issue 2292863002: Introduced new scheme for controlling the functionality inside the audio processing module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.h

Issue 2292863002: Introduced new scheme for controlling the functionality inside the audio processing module (Closed)

Patch Set: Removed the validation method and added logging of the config settings and revertion to default val… Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/echo_cancellation_impl.h

diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.h b/webrtc/modules/audio_processing/echo_cancellation_impl.h

index f67ef7b7da0b9d1dbba186de954982108de5842f..e44608a7893e0da2f5cb61176a90dcefa80406e9 100644

--- a/webrtc/modules/audio_processing/echo_cancellation_impl.h

+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.h

@@ -43,7 +43,7 @@ class EchoCancellationImpl : public EchoCancellation {

size_t num_reverse_channels_,

size_t num_output_channels_,

size_t num_proc_channels_);

- void SetExtraOptions(const Config& config);

+ void SetExtraOptions(const webrtc::Config& config);

bool is_delay_agnostic_enabled() const;

bool is_extended_filter_enabled() const;

bool is_aec3_enabled() const;