Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2292853002: GN: Fix resource files for iOS test target (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix resource files for iOS test target In order to get resource files to be properly packaged into the .app for a unit test on iOS, the resource files needs to be listed as sources in a bundle_data target. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/32c4a20df7a14ccdde4799742602b234dcbb987f Cr-Commit-Position: refs/heads/master@{#13968}

Patch Set 1 #

Patch Set 2 : Moved declaration to before first use for Android #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -167 lines) Patch
M webrtc/BUILD.gn View 1 4 chunks +52 lines, -19 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 1 2 chunks +17 lines, -4 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 2 chunks +26 lines, -10 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 5 chunks +140 lines, -115 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 2 chunks +18 lines, -5 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 2 chunks +25 lines, -10 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 2 chunks +17 lines, -4 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
kjellander_webrtc
The trybot results in https://codereview.webrtc.org/2291443002/#ps170001 proves that this is working for the iOS tests.
4 years, 3 months ago (2016-08-30 07:53:03 UTC) #2
ehmaldonado_webrtc
lgtm
4 years, 3 months ago (2016-08-30 07:56:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2292853002/20001
4 years, 3 months ago (2016-08-30 09:51:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 09:53:53 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/32c4a20df7a14ccdde4799742602b234dcbb987f Cr-Commit-Position: refs/heads/master@{#13968}
4 years, 3 months ago (2016-08-30 09:53:57 UTC) #9
kjellander_webrtc
4 years, 3 months ago (2016-08-30 11:11:08 UTC) #10
Message was sent while issue was closed.
Buildbots surfaced an error in this CL; I'm fixing it in
https://codereview.webrtc.org/2292923002/

https://codereview.webrtc.org/2292853002/diff/20001/webrtc/tools/BUILD.gn
File webrtc/tools/BUILD.gn (right):

https://codereview.webrtc.org/2292853002/diff/20001/webrtc/tools/BUILD.gn#new...
webrtc/tools/BUILD.gn:326: tools_unittests_resources = [
"//resources/foreman_cif_short.yuv" ]
This was a mistake. I must have pasted the wrong line.
I'm fixing it in https://codereview.webrtc.org/2292923002/

Powered by Google App Engine
This is Rietveld 408576698