Bugfixes for rtp_analyzer.py tool.

Bugfixes for rtp_analyzer.py tool.

2 fixes: When running tool on log with no packet losses, the tool no
longer crashes. When providing relative path to log, the tool no
longer searches in out/target, but instead in current directory.

NOTRY=True

Committed: https://crrev.com/e4b469558298b84c999cb18c81511e4083b6ad71
Cr-Commit-Position: refs/heads/master@{#13954}

[aleloi, 2016-08-29 11:37:33]

Two small bugfixes for bugs reported by tlegrand@ in event log tool. Please take
a look!

https://codereview.webrtc.org/2291473003/diff/1/webrtc/tools/py_event_log_ana...
File webrtc/tools/py_event_log_analyzer/rtp_analyzer.py (right):

https://codereview.webrtc.org/2291473003/diff/1/webrtc/tools/py_event_log_ana...
webrtc/tools/py_event_log_analyzer/rtp_analyzer.py:281: return
numpy.ma.masked_values(regularized_delays, -1)
masked_values(array, x) marks all positions |i| in array for which |array[i] =
x|.

If the array contains floats, it will use a special floating point comparison.

The array typically contains floats, except for cases when there is a >50 ms
gap. Then the value is None. The intended behavior is to mark the positions of
these gaps.

When there are *no* gaps (and no None values), numpy considers the array a
|float| array and use float comparisons. It cannot compare float with None, so
there is an error. In a networked environment there are always 50ms gaps, so the
bug went unnoticed until we tested with a local dump.

The change is to replace the |None|s with |-1|. It is an invalid value, as the
array contains absolute delays.

https://codereview.webrtc.org/2291473003/diff/1/webrtc/tools/py_event_log_ana...
webrtc/tools/py_event_log_analyzer/rtp_analyzer.py:309: data_points =
pb_parse.parse_protobuf(input_file)
Previously, you had to specify a log file with an absolute path or a connect
path relative to out/target. Now, the path can be relative to the current
directory and you can invoke the tool by

path/to/out/target/rtp_analyzer.sh logfile

[aleloi, 2016-08-29 11:38:03]

aleloi@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[aleloi, 2016-08-29 11:38:17]

Two small bugfixes for bugs reported by tlegrand@ in event log tool. Please take
a look!

[kwiberg-webrtc, 2016-08-29 11:49:44]

lgtm

https://codereview.webrtc.org/2291473003/diff/1/webrtc/tools/py_event_log_ana...
File webrtc/tools/py_event_log_analyzer/rtp_analyzer.py (right):

https://codereview.webrtc.org/2291473003/diff/1/webrtc/tools/py_event_log_ana...
webrtc/tools/py_event_log_analyzer/rtp_analyzer.py:281: return
numpy.ma.masked_values(regularized_delays, -1)
On 2016/08/29 11:37:33, aleloi wrote:
> masked_values(array, x) marks all positions |i| in array for which |array[i] =
> x|.
> 
> If the array contains floats, it will use a special floating point comparison.
> 
> The array typically contains floats, except for cases when there is a >50 ms
> gap. Then the value is None. The intended behavior is to mark the positions of
> these gaps.
> 
> When there are *no* gaps (and no None values), numpy considers the array a
> |float| array and use float comparisons. It cannot compare float with None, so
> there is an error. In a networked environment there are always 50ms gaps, so
the
> bug went unnoticed until we tested with a local dump.
> 
> The change is to replace the |None|s with |-1|. It is an invalid value, as the
> array contains absolute delays.

Acknowledged.

https://codereview.webrtc.org/2291473003/diff/1/webrtc/tools/py_event_log_ana...
webrtc/tools/py_event_log_analyzer/rtp_analyzer.py:309: data_points =
pb_parse.parse_protobuf(input_file)
On 2016/08/29 11:37:33, aleloi wrote:
> Previously, you had to specify a log file with an absolute path or a connect
> path relative to out/target. Now, the path can be relative to the current
> directory and you can invoke the tool by
> 
> path/to/out/target/rtp_analyzer.sh logfile

Acknowledged.

[aleloi, 2016-08-29 11:50:44]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2016-08-29 11:50:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-29 11:58:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-29 11:58:29]

Description was changed from

==========
Bugfixes for rtp_analyzer.py tool.

2 fixes: When running tool on log with no packet losses, the tool no
longer crashes. When providing relative path to log, the tool no
longer searches in out/target, but instead in current directory.

NOTRY=True
==========

to

==========
Bugfixes for rtp_analyzer.py tool.

2 fixes: When running tool on log with no packet losses, the tool no
longer crashes. When providing relative path to log, the tool no
longer searches in out/target, but instead in current directory.

NOTRY=True

Committed: https://crrev.com/e4b469558298b84c999cb18c81511e4083b6ad71
Cr-Commit-Position: refs/heads/master@{#13954}
==========

[commit-bot: I haz the power, 2016-08-29 11:58:30]

Patchset 1 (id:??) landed as
https://crrev.com/e4b469558298b84c999cb18c81511e4083b6ad71
Cr-Commit-Position: refs/heads/master@{#13954}