Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2291443002: MB: Flip iOS bots to GN by default (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Flip iOS bots to GN by default Change the previous GN configs to build GYP instead (since we'll keep GYP around for a while) but exclude tests and examples for that config, since we'll only support the production code for GYP. Add new configs for upcoming rename of those bots to GYP instead of GN. BUG=webrtc:5949 NOTRY=True TBR=ehmaldonado@webrtc.org Committed: https://crrev.com/6e5b0d7a5b80876a9a30a988bfa5f2eed76f759b Cr-Commit-Position: refs/heads/master@{#13980}

Patch Set 1 #

Patch Set 2 : MB: Flip all bots to GN #

Patch Set 3 : Fix desktop_capture and iOS bundles #

Patch Set 4 : Exclude differ* sources on iOS #

Patch Set 5 : Reverted common_audio change and rebased #

Patch Set 6 : Rebased after landing all the other CLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -46 lines) Patch
M webrtc/build/ios/client.webrtc/iOS32_Debug.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/client.webrtc/iOS32_Release.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/client.webrtc/iOS32_Simulator_Debug.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Debug.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Debug_(GN).json View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/build/ios/client.webrtc/iOS64_Debug_(GYP).json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Release.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Release_(GN).json View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/build/ios/client.webrtc/iOS64_Release_(GYP).json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/client.webrtc/iOS64_Simulator_Debug.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios32_sim_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios64_gn_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios64_gn_rel.json View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/build/ios/tryserver.webrtc/ios64_gyp_dbg.json View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/build/ios/tryserver.webrtc/ios64_gyp_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios64_sim_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_arm64_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_arm64_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_dbg.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/ios/tryserver.webrtc/ios_rel.json View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/build/mb_config.pyl View 1 2 4 chunks +34 lines, -26 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2291443002/270001
4 years, 3 months ago (2016-08-30 20:43:23 UTC) #14
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-08-30 20:43:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2291443002/270001
4 years, 3 months ago (2016-08-30 20:50:50 UTC) #19
commit-bot: I haz the power
Committed patchset #6 (id:270001)
4 years, 3 months ago (2016-08-30 21:05:48 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:05:55 UTC) #23
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6e5b0d7a5b80876a9a30a988bfa5f2eed76f759b
Cr-Commit-Position: refs/heads/master@{#13980}

Powered by Google App Engine
This is Rietveld 408576698