Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2291253003: Use max optimization when compiling neteq_performance_test. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use max optimization when compiling neteq_performance_test. The compiler optimization for Windows is O1 by default in GN, but O2 in GYP. This might help explain the regression observed on neteq_performance_unittest. NOTRY=True BUG=641966 Committed: https://crrev.com/25f32e723a979295ab033381bb0a028763b32683 Cr-Commit-Position: refs/heads/master@{#13999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M webrtc/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
ehmaldonado_webrtc
This should get windows to compile with O2 on Release builds, to test if it ...
4 years, 3 months ago (2016-08-31 13:30:09 UTC) #5
kjellander_webrtc
I guess we might only need one of the two targets, but it doesn't matter ...
4 years, 3 months ago (2016-08-31 14:14:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2291253003/20001
4 years, 3 months ago (2016-08-31 14:51:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-08-31 15:22:12 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 15:22:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25f32e723a979295ab033381bb0a028763b32683
Cr-Commit-Position: refs/heads/master@{#13999}

Powered by Google App Engine
This is Rietveld 408576698