Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2291023002: GN: Fix common_audio linking on iOS (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix common_audio linking on iOS The invalid condition made the test be included for iOS, which fails linking. BUG=webrtc:5949, webrtc:5544 NOTRY=True Committed: https://crrev.com/34db033cd4489f6bc6a60549a73e555aa57a5bc3 Cr-Commit-Position: refs/heads/master@{#13970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/common_audio/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
kjellander_webrtc
4 years, 3 months ago (2016-08-30 09:41:08 UTC) #2
ehmaldonado_webrtc
On 2016/08/30 09:41:08, kjellander_webrtc wrote: Only for arm?
4 years, 3 months ago (2016-08-30 09:44:38 UTC) #3
kjellander_webrtc
On 2016/08/30 09:44:38, ehmaldonado_webrtc wrote: > On 2016/08/30 09:41:08, kjellander_webrtc wrote: > > Only for ...
4 years, 3 months ago (2016-08-30 09:51:06 UTC) #4
ehmaldonado_webrtc
On 2016/08/30 09:51:06, kjellander_webrtc wrote: > On 2016/08/30 09:44:38, ehmaldonado_webrtc wrote: > > On 2016/08/30 ...
4 years, 3 months ago (2016-08-30 09:55:39 UTC) #6
kjellander_webrtc
On 2016/08/30 09:55:39, ehmaldonado_webrtc wrote: > On 2016/08/30 09:51:06, kjellander_webrtc wrote: > > On 2016/08/30 ...
4 years, 3 months ago (2016-08-30 11:14:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2291023002/1
4 years, 3 months ago (2016-08-30 11:14:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 11:17:16 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 11:17:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34db033cd4489f6bc6a60549a73e555aa57a5bc3
Cr-Commit-Position: refs/heads/master@{#13970}

Powered by Google App Engine
This is Rietveld 408576698