iOS: Add ability to specify audio constraints.

iOS: Add ability to specify audio constraints.

NOTRY=True
BUG=

Committed: https://crrev.com/d4bfbfc75ae99dfe648a86943ca3d5aa6b4a9cc8
Cr-Commit-Position: refs/heads/master@{#13976}

[tkchin_webrtc, 2016-08-30 00:15:08]

Description was changed from

==========
iOS: Add ability to specify audio constraints.

BUG=
==========

to

==========
iOS: Add ability to specify audio constraints.

BUG=
==========

[tkchin_webrtc, 2016-08-30 00:15:08]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, peah@webrtc.org

[peah-webrtc, 2016-08-30 10:27:29]

On 2016/08/30 00:21:14, tkchin_webrtc wrote:

Looks good!
lgtm But I'm not a Objective C developer so I need to rely on haysc@ to do a
careful review work.

[Chuck, 2016-08-30 14:28:37]

lgtm as well

https://codereview.webrtc.org/2290583003/diff/40001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCAudioSource+Private.h (right):

https://codereview.webrtc.org/2290583003/diff/40001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCAudioSource+Private.h:28: -
(instancetype)initWithNativeMediaSource:
These 2 ctors are in a different order than the video version, might be worth it
to swap them for consistency.

[tkchin_webrtc, 2016-08-30 18:48:07]

https://codereview.webrtc.org/2290583003/diff/40001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCAudioSource+Private.h (right):

https://codereview.webrtc.org/2290583003/diff/40001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCAudioSource+Private.h:28: -
(instancetype)initWithNativeMediaSource:
On 2016/08/30 14:28:37, Chuck wrote:
> These 2 ctors are in a different order than the video version, might be worth
it
> to swap them for consistency.

Done.

[tkchin_webrtc, 2016-08-30 18:48:19]

Description was changed from

==========
iOS: Add ability to specify audio constraints.

BUG=
==========

to

==========
iOS: Add ability to specify audio constraints.

NOTRY=True
BUG=
==========

[tkchin_webrtc, 2016-08-30 18:48:25]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-08-30 18:48:26]

The patchset sent to the CQ was uploaded after l-g-t-m from peah@webrtc.org,
haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2290583003/#ps60001 (title:
"Update ctor order.")

[commit-bot: I haz the power, 2016-08-30 18:48:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-30 18:56:09]

Description was changed from

==========
iOS: Add ability to specify audio constraints.

NOTRY=True
BUG=
==========

to

==========
iOS: Add ability to specify audio constraints.

NOTRY=True
BUG=
==========

[commit-bot: I haz the power, 2016-08-30 18:56:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 18:56:14]

Description was changed from

==========
iOS: Add ability to specify audio constraints.

NOTRY=True
BUG=
==========

to

==========
iOS: Add ability to specify audio constraints.

NOTRY=True
BUG=

Committed: https://crrev.com/d4bfbfc75ae99dfe648a86943ca3d5aa6b4a9cc8
Cr-Commit-Position: refs/heads/master@{#13976}
==========

[commit-bot: I haz the power, 2016-08-30 18:56:15]

Patchset 4 (id:??) landed as
https://crrev.com/d4bfbfc75ae99dfe648a86943ca3d5aa6b4a9cc8
Cr-Commit-Position: refs/heads/master@{#13976}