Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by ossu Modified:
4 years, 3 months ago Reviewers:
kwiberg-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdded an empty() method to rtc::Buffer
I'll be using it in a separate CL in a bit.
Committed: https://crrev.com/5955e24fe8355be21eb775385bcf9da78547e54e
Cr-Commit-Position: refs/heads/master@{#14001}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added IsConsistent() check #
Created: 4 years, 3 months ago
Dependent Patchsets: Messages
Total messages: 22 (10 generated)
ossu@webrtc.org changed reviewers: + kwiberg@webrtc.org
I'm aiming to use rtc::Buffer in a few more places and having an empty() method on it is quite useful.
lgtm https://codereview.webrtc.org/2290343002/diff/1/webrtc/base/buffer.h File webrtc/base/buffer.h (right): https://codereview.webrtc.org/2290343002/diff/1/webrtc/base/buffer.h#newcode127 webrtc/base/buffer.h:127: bool empty() const { return size_ == 0; } Since I'm paranoid, I'd like to see an RTC_DCHECK(IsConsistent()); in there as well.
https://codereview.webrtc.org/2290343002/diff/1/webrtc/base/buffer.h File webrtc/base/buffer.h (right): https://codereview.webrtc.org/2290343002/diff/1/webrtc/base/buffer.h#newcode127 webrtc/base/buffer.h:127: bool empty() const { return size_ == 0; } On 2016/08/30 15:34:12, kwiberg-webrtc wrote: > Since I'm paranoid, I'd like to see an > > RTC_DCHECK(IsConsistent()); > > in there as well. Done.
The CQ bit was checked by ossu@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org Link to the patchset: https://codereview.webrtc.org/2290343002/#ps20001 (title: "Added IsConsistent() check")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/2371)
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Added an empty() method to rtc::Buffer I'll be using it in a separate CL in a bit. ========== to ========== Added an empty() method to rtc::Buffer I'll be using it in a separate CL in a bit. Committed: https://crrev.com/5955e24fe8355be21eb775385bcf9da78547e54e Cr-Commit-Position: refs/heads/master@{#14001} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5955e24fe8355be21eb775385bcf9da78547e54e Cr-Commit-Position: refs/heads/master@{#14001} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
