Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: webrtc/voice_engine/channel.h

Issue 2290253002: Remove Channel::UpdatePacketDelay and some member variables (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/voice_engine/channel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 bool in_order); 459 bool in_order);
460 bool HandleRtxPacket(const uint8_t* packet, 460 bool HandleRtxPacket(const uint8_t* packet,
461 size_t packet_length, 461 size_t packet_length,
462 const RTPHeader& header); 462 const RTPHeader& header);
463 bool IsPacketInOrder(const RTPHeader& header) const; 463 bool IsPacketInOrder(const RTPHeader& header) const;
464 bool IsPacketRetransmitted(const RTPHeader& header, bool in_order) const; 464 bool IsPacketRetransmitted(const RTPHeader& header, bool in_order) const;
465 int ResendPackets(const uint16_t* sequence_numbers, int length); 465 int ResendPackets(const uint16_t* sequence_numbers, int length);
466 int32_t MixOrReplaceAudioWithFile(int mixingFrequency); 466 int32_t MixOrReplaceAudioWithFile(int mixingFrequency);
467 int32_t MixAudioWithFile(AudioFrame& audioFrame, int mixingFrequency); 467 int32_t MixAudioWithFile(AudioFrame& audioFrame, int mixingFrequency);
468 void UpdatePlayoutTimestamp(bool rtcp); 468 void UpdatePlayoutTimestamp(bool rtcp);
469 void UpdatePacketDelay(uint32_t timestamp, uint16_t sequenceNumber);
470 void RegisterReceiveCodecsToRTPModule(); 469 void RegisterReceiveCodecsToRTPModule();
471 470
472 int SetSendRtpHeaderExtension(bool enable, 471 int SetSendRtpHeaderExtension(bool enable,
473 RTPExtensionType type, 472 RTPExtensionType type,
474 unsigned char id); 473 unsigned char id);
475 474
476 int32_t GetPlayoutFrequency(); 475 int32_t GetPlayoutFrequency() const;
hlundin-webrtc 2016/08/30 12:19:49 This change is not exactly needed, but makes it cl
477 int64_t GetRTT(bool allow_associate_channel) const; 476 int64_t GetRTT(bool allow_associate_channel) const;
478 477
479 rtc::CriticalSection _fileCritSect; 478 rtc::CriticalSection _fileCritSect;
480 rtc::CriticalSection _callbackCritSect; 479 rtc::CriticalSection _callbackCritSect;
481 rtc::CriticalSection volume_settings_critsect_; 480 rtc::CriticalSection volume_settings_critsect_;
482 uint32_t _instanceId; 481 uint32_t _instanceId;
483 int32_t _channelId; 482 int32_t _channelId;
484 483
485 ChannelState channel_state_; 484 ChannelState channel_state_;
486 485
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 float _panRight GUARDED_BY(volume_settings_critsect_); 557 float _panRight GUARDED_BY(volume_settings_critsect_);
559 float _outputGain GUARDED_BY(volume_settings_critsect_); 558 float _outputGain GUARDED_BY(volume_settings_critsect_);
560 // VoeRTP_RTCP 559 // VoeRTP_RTCP
561 uint32_t _lastLocalTimeStamp; 560 uint32_t _lastLocalTimeStamp;
562 int8_t _lastPayloadType; 561 int8_t _lastPayloadType;
563 bool _includeAudioLevelIndication; 562 bool _includeAudioLevelIndication;
564 // VoENetwork 563 // VoENetwork
565 AudioFrame::SpeechType _outputSpeechType; 564 AudioFrame::SpeechType _outputSpeechType;
566 // VoEVideoSync 565 // VoEVideoSync
567 rtc::CriticalSection video_sync_lock_; 566 rtc::CriticalSection video_sync_lock_;
568 uint32_t _average_jitter_buffer_delay_us GUARDED_BY(video_sync_lock_);
569 uint32_t _previousTimestamp;
570 uint16_t _recPacketDelayMs GUARDED_BY(video_sync_lock_);
571 // VoEAudioProcessing 567 // VoEAudioProcessing
572 bool _RxVadDetection; 568 bool _RxVadDetection;
573 bool _rxAgcIsEnabled; 569 bool _rxAgcIsEnabled;
574 bool _rxNsIsEnabled; 570 bool _rxNsIsEnabled;
575 bool restored_packet_in_use_; 571 bool restored_packet_in_use_;
576 // RtcpBandwidthObserver 572 // RtcpBandwidthObserver
577 std::unique_ptr<VoERtcpObserver> rtcp_observer_; 573 std::unique_ptr<VoERtcpObserver> rtcp_observer_;
578 std::unique_ptr<NetworkPredictor> network_predictor_; 574 std::unique_ptr<NetworkPredictor> network_predictor_;
579 // An associated send channel. 575 // An associated send channel.
580 rtc::CriticalSection assoc_send_channel_lock_; 576 rtc::CriticalSection assoc_send_channel_lock_;
581 ChannelOwner associate_send_channel_ GUARDED_BY(assoc_send_channel_lock_); 577 ChannelOwner associate_send_channel_ GUARDED_BY(assoc_send_channel_lock_);
582 578
583 bool pacing_enabled_; 579 bool pacing_enabled_;
584 PacketRouter* packet_router_ = nullptr; 580 PacketRouter* packet_router_ = nullptr;
585 std::unique_ptr<TransportFeedbackProxy> feedback_observer_proxy_; 581 std::unique_ptr<TransportFeedbackProxy> feedback_observer_proxy_;
586 std::unique_ptr<TransportSequenceNumberProxy> seq_num_allocator_proxy_; 582 std::unique_ptr<TransportSequenceNumberProxy> seq_num_allocator_proxy_;
587 std::unique_ptr<RtpPacketSenderProxy> rtp_packet_sender_proxy_; 583 std::unique_ptr<RtpPacketSenderProxy> rtp_packet_sender_proxy_;
588 std::unique_ptr<RateLimiter> retransmission_rate_limiter_; 584 std::unique_ptr<RateLimiter> retransmission_rate_limiter_;
589 585
590 // TODO(ossu): Remove once GetAudioDecoderFactory() is no longer needed. 586 // TODO(ossu): Remove once GetAudioDecoderFactory() is no longer needed.
591 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_; 587 rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
592 }; 588 };
593 589
594 } // namespace voe 590 } // namespace voe
595 } // namespace webrtc 591 } // namespace webrtc
596 592
597 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_H_ 593 #endif // WEBRTC_VOICE_ENGINE_CHANNEL_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/voice_engine/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698