Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2290253002: Remove Channel::UpdatePacketDelay and some member variables (Closed)

Created:
4 years, 3 months ago by hlundin-webrtc
Modified:
4 years, 3 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove Channel::UpdatePacketDelay and some member variables The method is no longer used, since the jitter buffer delay is obtained directly from AudioCodingModule instead of being calculated and smoothed in VoiceEngine. Deleting a few obsolete member variables as well. BUG=webrtc:6237 Committed: https://crrev.com/b3e30010de6a03def6c17ffd5cde759d618e68ff Cr-Commit-Position: refs/heads/master@{#14007}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -76 lines) Patch
M webrtc/voice_engine/channel.h View 2 chunks +1 line, -5 lines 1 comment Download
M webrtc/voice_engine/channel.cc View 4 chunks +1 line, -71 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
hlundin-webrtc
PTAL https://codereview.webrtc.org/2290253002/diff/1/webrtc/voice_engine/channel.h File webrtc/voice_engine/channel.h (right): https://codereview.webrtc.org/2290253002/diff/1/webrtc/voice_engine/channel.h#newcode475 webrtc/voice_engine/channel.h:475: int32_t GetPlayoutFrequency() const; This change is not exactly ...
4 years, 3 months ago (2016-08-30 12:19:49 UTC) #2
the sun
lgtm
4 years, 3 months ago (2016-08-30 15:40:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2290253002/1
4 years, 3 months ago (2016-08-31 10:47:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) ios64_gn_rel on ...
4 years, 3 months ago (2016-08-31 10:48:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2290253002/1
4 years, 3 months ago (2016-08-31 17:47:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-08-31 19:47:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2290253002/1
4 years, 3 months ago (2016-08-31 21:01:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 21:09:56 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 21:10:02 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3e30010de6a03def6c17ffd5cde759d618e68ff
Cr-Commit-Position: refs/heads/master@{#14007}

Powered by Google App Engine
This is Rietveld 408576698