Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2289563002: Fix multiple definitions of BasicPacketSocketFactory error and add stunprober in GN. (Closed)

Created:
4 years, 3 months ago by wjywbs
Modified:
4 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix multiple definitions of BasicPacketSocketFactory error and add stunprober in GN. R=pthatcher@webrtc.org Committed: https://crrev.com/5a601d909fa4231d498a920ca74eec96a3c593b0 Cr-Commit-Position: refs/heads/master@{#14006}

Patch Set 1 #

Patch Set 2 : Add field_trial_default. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M webrtc/p2p/BUILD.gn View 1 1 chunk +18 lines, -0 lines 0 comments Download
M webrtc/p2p/stunprober/main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
wjywbs
PTAL, thanks.
4 years, 3 months ago (2016-08-29 04:50:53 UTC) #1
pthatcher1
lgtm
4 years, 3 months ago (2016-08-29 20:22:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2289563002/1
4 years, 3 months ago (2016-08-29 20:50:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/6436) android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 3 months ago (2016-08-29 20:54:27 UTC) #6
wjywbs
I added system_wrappers:field_trial_default to try to fix the build failures. Please check again.
4 years, 3 months ago (2016-08-30 16:59:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2289563002/20001
4 years, 3 months ago (2016-08-31 01:41:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-08-31 03:41:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2289563002/20001
4 years, 3 months ago (2016-08-31 20:55:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 21:03:55 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 21:04:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a601d909fa4231d498a920ca74eec96a3c593b0
Cr-Commit-Position: refs/heads/master@{#14006}

Powered by Google App Engine
This is Rietveld 408576698