Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: webrtc/base/optional.cc

Issue 2289383002: rtc::Optional: Tell sanitizers that unset values aren't OK to access (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/optional.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/optional.cc
diff --git a/webrtc/base/logging_mac.mm b/webrtc/base/optional.cc
similarity index 63%
copy from webrtc/base/logging_mac.mm
copy to webrtc/base/optional.cc
index ffee3541a48245e0179670ce2b013f957bc6b88a..6bebdd5a19225fcf46424e97c95d28ccba1b800e 100644
--- a/webrtc/base/logging_mac.mm
+++ b/webrtc/base/optional.cc
@@ -8,15 +8,16 @@
* be found in the AUTHORS file in the root of the source tree.
*/
-#include "webrtc/base/logging.h"
+#include "webrtc/base/optional.h"
-#import <Foundation/Foundation.h>
+namespace rtc {
+namespace optional_internal {
+#if RTC_HAS_ASAN
-namespace rtc {
-std::string DescriptionFromOSStatus(OSStatus err) {
- NSError* error =
- [NSError errorWithDomain:NSOSStatusErrorDomain code:err userInfo:nil];
- return error.description.UTF8String;
-}
+void* FunctionThatDoesNothingImpl(void* x) { return x; }
+
+#endif
+
+} // namespace optional_internal
} // namespace rtc
« no previous file with comments | « webrtc/base/optional.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698