Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2289303005: Fix a race condition where Camera2Session forgot to return the texture frame when closing the camer… (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a race condition where Camera2Session forgot to return the texture frame when closing the camera. BUG=b/31201445 Committed: https://crrev.com/8a2098cb8db1a7e74fd5aaf6dd32a79d99010423 Cr-Commit-Position: refs/heads/master@{#14015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/api/android/java/src/org/webrtc/Camera2Session.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
sakal
PTAL
4 years, 3 months ago (2016-09-01 07:37:52 UTC) #5
magjed_webrtc
lgtm
4 years, 3 months ago (2016-09-01 07:42:16 UTC) #6
magjed_webrtc
Can we write a test for this?
4 years, 3 months ago (2016-09-01 07:44:18 UTC) #7
sakal
I guess I can write a test that will try to start and stop the ...
4 years, 3 months ago (2016-09-01 07:57:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2289303005/1
4 years, 3 months ago (2016-09-01 08:58:14 UTC) #12
magjed_webrtc
On 2016/09/01 07:57:05, sakal wrote: > I guess I can write a test that will ...
4 years, 3 months ago (2016-09-01 09:02:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 09:07:05 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 09:07:17 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a2098cb8db1a7e74fd5aaf6dd32a79d99010423
Cr-Commit-Position: refs/heads/master@{#14015}

Powered by Google App Engine
This is Rietveld 408576698