Fix a race condition where Camera2Session forgot to return the texture frame when closing the camer…

Fix a race condition where Camera2Session forgot to return the texture frame when closing the camera.

BUG=b/31201445

Committed: https://crrev.com/8a2098cb8db1a7e74fd5aaf6dd32a79d99010423
Cr-Commit-Position: refs/heads/master@{#14015}

[sakal, 2016-09-01 07:37:36]

The CQ bit was checked by sakal@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 07:37:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-09-01 07:37:46]

Description was changed from

==========
Fix a race condition where Camera2Session forgot to return the texture frame
when closing the camera.

BUG=b/31201445
==========

to

==========
Fix a race condition where Camera2Session forgot to return the texture frame
when closing the camera.

BUG=b/31201445
==========

[sakal, 2016-09-01 07:37:46]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-09-01 07:37:52]

PTAL

[magjed_webrtc, 2016-09-01 07:42:16]

lgtm

[magjed_webrtc, 2016-09-01 07:44:18]

Can we write a test for this?

[sakal, 2016-09-01 07:57:05]

I guess I can write a test that will try to start and stop the camera a lot of
times and see if we still receive frames.

[commit-bot: I haz the power, 2016-09-01 08:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 08:53:24]

Dry run: This issue passed the CQ dry run.

[sakal, 2016-09-01 08:58:08]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-09-01 08:58:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-09-01 09:02:21]

On 2016/09/01 07:57:05, sakal wrote:
> I guess I can write a test that will try to start and stop the camera a lot of
> times and see if we still receive frames.

I was hoping for a deterministic test to detect this, but it looks hard to add.
A stress test that will start and stop the camera multiple times and see if we
still receive frames will hopefully detect most of these cases.

[commit-bot: I haz the power, 2016-09-01 09:07:04]

Description was changed from

==========
Fix a race condition where Camera2Session forgot to return the texture frame
when closing the camera.

BUG=b/31201445
==========

to

==========
Fix a race condition where Camera2Session forgot to return the texture frame
when closing the camera.

BUG=b/31201445
==========

[commit-bot: I haz the power, 2016-09-01 09:07:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-01 09:07:15]

Description was changed from

==========
Fix a race condition where Camera2Session forgot to return the texture frame
when closing the camera.

BUG=b/31201445
==========

to

==========
Fix a race condition where Camera2Session forgot to return the texture frame
when closing the camera.

BUG=b/31201445

Committed: https://crrev.com/8a2098cb8db1a7e74fd5aaf6dd32a79d99010423
Cr-Commit-Position: refs/heads/master@{#14015}
==========

[commit-bot: I haz the power, 2016-09-01 09:07:17]

Patchset 1 (id:??) landed as
https://crrev.com/8a2098cb8db1a7e74fd5aaf6dd32a79d99010423
Cr-Commit-Position: refs/heads/master@{#14015}