Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: webrtc/base/base.gyp

Issue 2289203002: Do not build task_queue.cc and include from webrtc_overrides in Chrome. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../build/common.gypi', ], 10 'includes': [ '../build/common.gypi', ],
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 { 134 {
135 'target_name': 'rtc_task_queue', 135 'target_name': 'rtc_task_queue',
136 'type': 'static_library', 136 'type': 'static_library',
137 'dependencies': [ 137 'dependencies': [
138 'rtc_base_approved', 138 'rtc_base_approved',
139 ], 139 ],
140 'sources': [ 140 'sources': [
141 'sequenced_task_checker.h', 141 'sequenced_task_checker.h',
142 'sequenced_task_checker_impl.cc', 142 'sequenced_task_checker_impl.cc',
143 'sequenced_task_checker_impl.h', 143 'sequenced_task_checker_impl.h',
144 'task_queue.h',
145 'task_queue_posix.h',
146 ], 144 ],
147 'conditions': [ 145 'conditions': [
148 ['build_libevent==1', { 146 ['build_with_chromium==1', {
149 'dependencies': [ 147 'include_dirs': [
150 '<(DEPTH)/base/third_party/libevent/libevent.gyp:libevent', 148 '../../webrtc_overrides'
151 ], 149 ],
152 }], 150 'sources' : [
153 ['enable_libevent==1', { 151 '../../webrtc_overrides/webrtc/base/task_queue.h',
154 'sources': [ 152 ]
tommi 2016/08/30 16:26:04 Remove this section. We don't explicitly add overr
perkj_webrtc 2016/08/30 20:00:18 This is inline with how we build logging.cc and h
155 'task_queue_libevent.cc', 153 } , {
156 'task_queue_posix.cc', 154 # If not build for chromium, use our own implementation.
155 'sources' : [
156 'task_queue.h',
157 'task_queue_posix.h',
157 ], 158 ],
158 'defines': [ 'WEBRTC_BUILD_LIBEVENT' ],
159 'all_dependent_settings': {
160 'defines': [ 'WEBRTC_BUILD_LIBEVENT' ]
161 },
162 }, {
163 # If not libevent, fall back to the other task queues.
164 'conditions': [ 159 'conditions': [
165 ['OS=="mac" or OS=="ios"', { 160 ['build_libevent==1', {
166 'sources': [ 161 'dependencies': [
167 'task_queue_gcd.cc', 162 '<(DEPTH)/base/third_party/libevent/libevent.gyp:libevent',
168 'task_queue_posix.cc', 163 ],
169 ],
170 }], 164 }],
171 ['OS=="win"', { 165 ['enable_libevent==1', {
172 'sources': [ 'task_queue_win.cc' ], 166 'sources': [
173 }] 167 'task_queue_libevent.cc',
174 ], 168 'task_queue_posix.cc',
169 ],
170 'defines': [ 'WEBRTC_BUILD_LIBEVENT' ],
171 'all_dependent_settings': {
172 'defines': [ 'WEBRTC_BUILD_LIBEVENT' ]
173 },
174 }, {
175 # If not libevent, fall back to the other task queues.
176 'conditions': [
177 ['OS=="mac" or OS=="ios"', {
178 'sources': [
179 'task_queue_gcd.cc',
180 'task_queue_posix.cc',
181 ],
182 }],
183 ['OS=="win"', {
184 'sources': [ 'task_queue_win.cc' ],
185 }]
186 ],
187 }],
188 ]
175 }], 189 }],
176 ], 190 ],
177 }, 191 },
178 { 192 {
179 'target_name': 'rtc_base', 193 'target_name': 'rtc_base',
180 'type': 'static_library', 194 'type': 'static_library',
181 'dependencies': [ 195 'dependencies': [
182 '<(webrtc_root)/common.gyp:webrtc_common', 196 '<(webrtc_root)/common.gyp:webrtc_common',
183 'rtc_base_approved', 197 'rtc_base_approved',
184 ], 198 ],
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
652 }, 666 },
653 { 667 {
654 'target_name': 'gtest_prod', 668 'target_name': 'gtest_prod',
655 'type': 'static_library', 669 'type': 'static_library',
656 'sources': [ 670 'sources': [
657 'gtest_prod_util.h', 671 'gtest_prod_util.h',
658 ], 672 ],
659 }, 673 },
660 ], 674 ],
661 } 675 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698