Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2289103002: Desktop capture: Fix GN target and exclude differ* sources on iOS (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Desktop capture: Fix GN target and exclude differ* sources on iOS Fix some out-of-sync differences between GYP and GN targets for desktop capture. Remove sources that aren't used on iOS for that platform, to solve linking errors that surfaced when flipping iOS to GN by default. BUG=webrtc:5949 NOTRY=True TBR=sergeyu@chromium.org Committed: https://crrev.com/131c958187352d52611256816bd12bd7d413d283 Cr-Commit-Position: refs/heads/master@{#13971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -98 lines) Patch
M webrtc/modules/desktop_capture/BUILD.gn View 2 chunks +9 lines, -5 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture.gypi View 5 chunks +106 lines, -93 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
4 years, 3 months ago (2016-08-30 09:44:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2289103002/1
4 years, 3 months ago (2016-08-30 11:14:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 11:24:02 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 11:24:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/131c958187352d52611256816bd12bd7d413d283
Cr-Commit-Position: refs/heads/master@{#13971}

Powered by Google App Engine
This is Rietveld 408576698