Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: webrtc/media/base/videoframe.h

Issue 2287233002: Delete cricket::VideoFrame::ConvertToRgbBuffer. (Closed)
Patch Set: Convert non-linux renderers. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/videoframe.h
diff --git a/webrtc/media/base/videoframe.h b/webrtc/media/base/videoframe.h
index 88d97358f1c75a12d309f3cc20f08e8f529310b7..c3d45f650ee6c896f4ec7532f9d782237eceb6e2 100644
--- a/webrtc/media/base/videoframe.h
+++ b/webrtc/media/base/videoframe.h
@@ -63,19 +63,6 @@ class VideoFrame {
// method on VideoFrameBuffer.
virtual const VideoFrame* GetCopyWithRotationApplied() const = 0;
- // Converts the I420 data to RGB of a certain type such as ARGB and ABGR.
- // Returns the frame's actual size, regardless of whether it was written or
- // not (like snprintf). Parameters size and stride_rgb are in units of bytes.
- // If there is insufficient space, nothing is written.
-
- // TODO(nisse): Deprecated. Should be moved or deleted in the
- // cricket::VideoFrame and webrtc::VideoFrame merge. Use
- // libyuv::ConvertFromI420 directly instead.
- virtual size_t ConvertToRgbBuffer(uint32_t to_fourcc,
- uint8_t* buffer,
- size_t size,
- int stride_rgb) const;
-
// Tests if sample is valid. Returns true if valid.
// TODO(nisse): Deprecated. Should be deleted in the cricket::VideoFrame and

Powered by Google App Engine
This is Rietveld 408576698