Delete cricket::VideoFrame::ConvertToRgbBuffer.

Delete cricket::VideoFrame::ConvertToRgbBuffer.

Users are updated to call libyuv functions directly. Also delete
related unit tests.

BUG=webrtc:5682
Committed: https://crrev.com/9f8e37b6f833cb6c821c6f401421b7c33cbe4b27
Cr-Commit-Position: refs/heads/master@{#14013}

[nisse-webrtc, 2016-08-29 10:49:06]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 10:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2016-08-29 10:49:30]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org

[commit-bot: I haz the power, 2016-08-29 10:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 10:50:42]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15918)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/13770)

[nisse-webrtc, 2016-08-29 11:05:22]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 11:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-29 11:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 11:11:16]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15919)

[perkj_webrtc, 2016-08-30 07:13:39]

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/examples/peerconne...
File webrtc/examples/peerconnection/client/linux/main_wnd.cc (right):

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/linux/main_wnd.cc:494: // TODO(henrike):
Convert directly to RGBA
Did you check if there is a RGBA convert in libyuv?

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/linux/main_wnd.cc:502:
cricket::FOURCC_ARGB);
use libyuv type not cricket::FOURCC_...

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/base/videofr...
File webrtc/media/base/videoframe_unittest.h (left):

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/base/videofr...
webrtc/media/base/videoframe_unittest.h:1768: ConvertToBuffer(2, 0, true, FROM,
kError,
these are all tested as part of libyuv instead?

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/devices/carb...
File webrtc/media/devices/carbonvideorenderer.cc (right):

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/devices/carb...
webrtc/media/devices/carbonvideorenderer.cc:124: cricket::FOURCC_ABGR);
should use a libyuv type, not cricket.

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/devices/gdiv...
File webrtc/media/devices/gdivideorenderer.cc (right):

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/devices/gdiv...
webrtc/media/devices/gdivideorenderer.cc:236: cricket::FOURCC_ARGB);
libuyv type- not cricket.

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/devices/gtkv...
File webrtc/media/devices/gtkvideorenderer.cc (right):

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/devices/gtkv...
webrtc/media/devices/gtkvideorenderer.cc:99: buffer->width(), buffer->height(),
dito

[nisse-webrtc, 2016-08-30 07:46:07]

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/examples/peerconne...
File webrtc/examples/peerconnection/client/linux/main_wnd.cc (right):

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/linux/main_wnd.cc:494: // TODO(henrike):
Convert directly to RGBA
On 2016/08/30 07:13:39, perkj_webrtc wrote:
> Did you check if there is a RGBA convert in libyuv?

There is, it seems. One could also call I420ToRGBA directly, without going via
ConvertFromI420. And similarly for the other calls. Which is better in most
ways.

I'll give it a try. I'm just a little bit worried about making changes to files
which lack tests completely.

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/base/videofr...
File webrtc/media/base/videoframe_unittest.h (left):

https://codereview.webrtc.org/2287233002/diff/40001/webrtc/media/base/videofr...
webrtc/media/base/videoframe_unittest.h:1768: ConvertToBuffer(2, 0, true, FROM,
kError,
On 2016/08/30 07:13:39, perkj_webrtc wrote:
> these are all tested as part of libyuv instead? 

I can't say if they have the same coverage, but there are unit tests in libyuv,
see
https://cs.chromium.org/chromium/src/third_party/libyuv/unit_test/convert_tes...

[perkj_webrtc, 2016-08-30 11:17:20]

lgtm if the build error is fixed.

https://codereview.webrtc.org/2287233002/diff/80001/webrtc/examples/peerconne...
File webrtc/examples/peerconnection/client/linux/main_wnd.cc (right):

https://codereview.webrtc.org/2287233002/diff/80001/webrtc/examples/peerconne...
webrtc/examples/peerconnection/client/linux/main_wnd.cc:17: // I420ToRGBA is
declared in convert_from.h, not convert_argb.h.
please remove this comment.

[nisse-webrtc, 2016-08-30 12:22:03]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 12:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-30 12:34:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:34:24]

Dry run: Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15990)

[nisse-webrtc, 2016-08-30 12:41:24]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-08-30 12:41:25]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2287233002/#ps100001 (title:
"Fix windows compile. Delete unneeded comment.")

[commit-bot: I haz the power, 2016-08-30 12:41:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-30 12:58:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:58:44]

Try jobs failed on following builders:
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15996)

[nisse-webrtc, 2016-08-30 13:23:37]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-08-30 13:23:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-30 14:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 14:22:40]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[nisse-webrtc, 2016-08-31 13:40:37]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-08-31 13:40:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 13:41:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 13:41:51]

Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[nisse-webrtc, 2016-08-31 13:59:42]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-08-31 13:59:42]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2287233002/#ps120001 (title:
"Rebase.")

[commit-bot: I haz the power, 2016-08-31 13:59:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 14:01:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 14:01:01]

Try jobs failed on following builders:
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)

[nisse-webrtc, 2016-09-01 07:17:25]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-09-01 07:17:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-01 08:06:26]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-01 08:06:33]

Description was changed from

==========
Delete cricket::VideoFrame::ConvertToRgbBuffer.

Users are updated to call libyuv functions directly. Also delete
related unit tests.

BUG=webrtc:5682
==========

to

==========
Delete cricket::VideoFrame::ConvertToRgbBuffer.

Users are updated to call libyuv functions directly. Also delete
related unit tests.

BUG=webrtc:5682

Committed: https://crrev.com/9f8e37b6f833cb6c821c6f401421b7c33cbe4b27
Cr-Commit-Position: refs/heads/master@{#14013}
==========

[commit-bot: I haz the power, 2016-09-01 08:06:34]

Patchset 7 (id:??) landed as
https://crrev.com/9f8e37b6f833cb6c821c6f401421b7c33cbe4b27
Cr-Commit-Position: refs/heads/master@{#14013}