Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2285713002: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings BUG=webrtc:163 Committed: https://crrev.com/8cf8898973560181152d329f9f47b5070dcbf2ee Cr-Commit-Position: refs/heads/master@{#13943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.h View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/agc/agc.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/vad/voice_activity_detector.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/vad/voice_activity_detector.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-08-26 14:06:37 UTC) #2
aleloi
Looks straight-forward enough. Lgtm!
4 years, 3 months ago (2016-08-26 14:08:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2285713002/1
4 years, 3 months ago (2016-08-26 14:10:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-08-26 15:26:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2285713002/1
4 years, 3 months ago (2016-08-26 21:49:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 21:50:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:50:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cf8898973560181152d329f9f47b5070dcbf2ee
Cr-Commit-Position: refs/heads/master@{#13943}

Powered by Google App Engine
This is Rietveld 408576698