New static I420Buffer::Rotate method, to replace GetCopyWithRotationApplied.

webrtc/media/devices/carbonvideorenderer.cc

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 88 matching lines @@
     image_width_ = width;
     image_height_ = height;
     image_.reset(new uint8_t[width * height * 4]);
     memset(image_.get(), 255, width * height * 4);
   }
   return true;
 }
 
 void CarbonVideoRenderer::OnFrame(const VideoFrame& video_frame) {
   {
-    const VideoFrame* frame = video_frame->GetCopyWithRotationApplied();
-
-    if (!SetSize(frame->width(), frame->height())) {

[magjed_webrtc, 2016/08/26 12:04:15]

Don't we need this SetSize call anymore? It looks dangerous to remove it.

[nisse-webrtc, 2016/08/26 12:31:40]

Good catch, that was not an intended change.

(And we should try to delete webrtc/media/devices/, the code isn't used within
webrtc, and there are no tests, so it'll inevitably suffer some bitrot. Users of
the code should at some point transition to using the renderers under
webrtc/test).

-      return false;
-    }
+    const cricket::WebRtcVideoFrame frame(
+        webrtc::VideoFrameBuffer::Rotate(video_frame.video_frame_buffer(),
+                                         video_frame.rotation()),
+        webrtc::kVideoRotation_0,
+        video_frame.timestamp_us());
 
     // Grab the image lock so we are not trashing up the image being drawn.
     rtc::CritScope cs(&image_crit_);
-    frame->ConvertToRgbBuffer(cricket::FOURCC_ABGR,
-                              image_.get(),
-                              static_cast<size_t>(frame->width()) *
-                                frame->height() * 4,
-                              frame->width() * 4);
+    frame.ConvertToRgbBuffer(cricket::FOURCC_ABGR,
+                             image_.get(),
+                             static_cast<size_t>(frame.width()) *
+                                 frame.height() * 4,
+                             frame.width() * 4);
   }
 
   // Trigger a repaint event for the whole window.
   Rect bounds;
   InvalWindowRect(window_ref_, GetWindowPortBounds(window_ref_, &bounds));
   return true;
 }
 
 bool CarbonVideoRenderer::Initialize() {
   OSStatus err;
@@ skipping 29 matching lines @@
   if (err != noErr) {
     LOG(LS_ERROR) << "Failed to install event handler, error code: " << err;
     return false;
   }
   SelectWindow(window_ref_);
   ShowWindow(window_ref_);
   return true;
 }
 
 }  // namespace cricket