Add parameter to TransportController to not change ICE role on restart.

Add parameter to TransportController to not change ICE role on restart.

This will allow applications to opt in to this behavior before it's made
default.

R=skvlad@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/f0bb360eca3556ef74d87e14095d18d7a34a556f

[skvlad, 2016-08-26 23:02:34]

skvlad@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[skvlad, 2016-08-26 23:02:35]

lgtm

https://codereview.webrtc.org/2285453002/diff/1/webrtc/p2p/base/transportcont...
File webrtc/p2p/base/transportcontroller_unittest.cc (right):

https://codereview.webrtc.org/2285453002/diff/1/webrtc/p2p/base/transportcont...
webrtc/p2p/base/transportcontroller_unittest.cc:743: // The endpoint that
initiated an ICE restart should take the controlling
"should keep the previous role"?

[Taylor Brandstetter, 2016-08-26 23:13:03]

https://codereview.webrtc.org/2285453002/diff/1/webrtc/p2p/base/transportcont...
File webrtc/p2p/base/transportcontroller_unittest.cc (right):

https://codereview.webrtc.org/2285453002/diff/1/webrtc/p2p/base/transportcont...
webrtc/p2p/base/transportcontroller_unittest.cc:743: // The endpoint that
initiated an ICE restart should take the controlling
On 2016/08/26 23:02:35, skvlad wrote:
> "should keep the previous role"?

Good catch.

[Taylor Brandstetter, 2016-08-26 23:13:09]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2016-08-26 23:13:09]

The patchset sent to the CQ was uploaded after l-g-t-m from skvlad@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2285453002/#ps20001 (title:
"Fixing copy-pasted comment.")

[commit-bot: I haz the power, 2016-08-26 23:13:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-27 01:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:13:34]

Try jobs failed on following builders:
  mac_gn_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[commit-bot: I haz the power, 2016-08-27 03:59:41]

Description was changed from

==========
Add parameter to TransportController to not change ICE role on restart.

This will allow applications to opt in to this behavior before it's made
default.
==========

to

==========
Add parameter to TransportController to not change ICE role on restart.

This will allow applications to opt in to this behavior before it's made
default.

R=skvlad@webrtc.org

Committed: https://crrev.com/f0bb360eca3556ef74d87e14095d18d7a34a556f
Cr-Commit-Position: refs/heads/master@{#13944}
==========

[Taylor Brandstetter, 2016-08-27 03:59:41]

Description was changed from

==========
Add parameter to TransportController to not change ICE role on restart.

This will allow applications to opt in to this behavior before it's made
default.
==========

to

==========
Add parameter to TransportController to not change ICE role on restart.

This will allow applications to opt in to this behavior before it's made
default.

R=skvlad@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f0bb360eca3556ef74d87e140...
==========

[commit-bot: I haz the power, 2016-08-27 03:59:41]

Patchset 2 (id:??) landed as
https://crrev.com/f0bb360eca3556ef74d87e14095d18d7a34a556f
Cr-Commit-Position: refs/heads/master@{#13944}

[Taylor Brandstetter, 2016-08-27 03:59:42]

Committed patchset #2 (id:20001) manually as
f0bb360eca3556ef74d87e14095d18d7a34a556f (presubmit successful).