Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2283793002: Revert of Added functionality for specifying the initial signal level to use for the gain estimation (Closed)

Created:
4 years, 3 months ago by peah-webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added functionality for specifying the initial signal level to use for the gain estimation in the l… (patchset #8 id:160001 of https://codereview.webrtc.org/2254973003/ ) Reason for revert: This caused build breakage due to upstream dependencies. These dependencies need to be resolved before landing the CL. Original issue's description: > This CL adds functionality in the level controller to > receive a signal level to use initially, instead of the > default initial signal level. > > BUG= > > Committed: https://crrev.com/57fec1d828113241186e78710ec5e851cc1a0e81 > Cr-Commit-Position: refs/heads/master@{#13931} TBR=henrik.lundin@webrtc.org,aleloi@webrtc.org,solenberg@webrtc.org,henrika@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7d67e451046ce760b63c36d0b2ae0b393514df6b Cr-Commit-Position: refs/heads/master@{#13936}

Patch Set 1 #

Messages

Total messages: 5 (3 generated)
peah-webrtc
Created Revert of Added functionality for specifying the initial signal level to use for the ...
4 years, 3 months ago (2016-08-26 13:20:12 UTC) #2
hlundin-webrtc
4 years, 3 months ago (2016-08-29 11:50:56 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698