Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2283763002:
Delete deprecated and unused method VideoFrame::SetTimeStamp. (Closed)
|
Created:
4 years, 3 months ago by nisse-webrtc Modified:
4 years, 3 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionDelete deprecated and unused method VideoFrame::SetTimeStamp.
BUG=webrtc:5682
Committed: https://crrev.com/ebb8d042879273aced7c8bba5979a989a3a25c10
Cr-Commit-Position: refs/heads/master@{#13948}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
nisse@webrtc.org changed reviewers: + magjed@webrtc.org
PTAL. This one is easy.
lgtm
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) android_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) linux_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) linux_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) mac_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) win_x64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) win_x64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) android_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) linux_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) linux_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) mac_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) win_x64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) win_x64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) android_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) linux_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) linux_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) mac_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) win_x64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) win_x64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
The CQ bit was checked by nisse@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Delete deprecated and unused method VideoFrame::SetTimeStamp. BUG=webrtc:5682 ========== to ========== Delete deprecated and unused method VideoFrame::SetTimeStamp. BUG=webrtc:5682 Committed: https://crrev.com/ebb8d042879273aced7c8bba5979a989a3a25c10 Cr-Commit-Position: refs/heads/master@{#13948} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ebb8d042879273aced7c8bba5979a989a3a25c10 Cr-Commit-Position: refs/heads/master@{#13948} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
