Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2283743003:
Add local capturer on mac (Closed)
|
Created:
4 years, 3 months ago by kthelgason Modified:
4 years, 3 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd local capturer on mac
BUG=webrtc:3417
Committed: https://crrev.com/314bc5f8e4075468b0812a547692036541b0e819
Cr-Commit-Position: refs/heads/master@{#14004}
Patch Set 1 : Add AppRTCDemo local capturer on mac #
Total comments: 1
Patch Set 2 : Rename single-letter variables #Patch Set 3 : rebase to master #
Messages
Total messages: 35 (18 generated)
Patchset #1 (id:1) has been deleted
kthelgason@webrtc.org changed reviewers: + magjed@webrtc.org, tkchin@webrtc.org
Description was changed from ========== Add local capturer on mac BUG= ========== to ========== Add local capturer on mac BUG=webrtc:3417 ==========
lgtm https://codereview.webrtc.org/2283743003/diff/20001/webrtc/examples/objc/AppR... File webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m (right): https://codereview.webrtc.org/2283743003/diff/20001/webrtc/examples/objc/AppR... webrtc/examples/objc/AppRTCDemo/mac/APPRTCViewController.m:210: NSInteger w = MAX(_remoteVideoSize.width, kContentWidth); nits: width, height (w / 16)
lgtm
The CQ bit was checked by kthelgason@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from tkchin@webrtc.org Link to the patchset: https://codereview.webrtc.org/2283743003/#ps40001 (title: "Rename single-letter variables")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15963)
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/15975)
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/2402)
The CQ bit was checked by kthelgason@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org, tkchin@webrtc.org Link to the patchset: https://codereview.webrtc.org/2283743003/#ps60001 (title: "rebase to master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
On 2016/08/31 13:27:01, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED, no build URL) > ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL) Those failures are unrelated to your CL. I would just go ahead and 'git cl land' it. Make sure you haven't done any local changes from the latest uploaded patch, because 'git cl land' will land whatever local commit you have.
The CQ bit was checked by kthelgason@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Add local capturer on mac BUG=webrtc:3417 ========== to ========== Add local capturer on mac BUG=webrtc:3417 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add local capturer on mac BUG=webrtc:3417 ========== to ========== Add local capturer on mac BUG=webrtc:3417 Committed: https://crrev.com/314bc5f8e4075468b0812a547692036541b0e819 Cr-Commit-Position: refs/heads/master@{#14004} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/314bc5f8e4075468b0812a547692036541b0e819 Cr-Commit-Position: refs/heads/master@{#14004} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
