Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: webrtc/examples/BUILD.gn

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)
Patch Set: Revert mb_config.pyl. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/examples/BUILD.gn
diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn
index 8b1f1877642d4acf2378f09e985a350aa7c4a6d7..c8078f46bf1e60fdd4b536953e8d08a9b7a2590c 100644
--- a/webrtc/examples/BUILD.gn
+++ b/webrtc/examples/BUILD.gn
@@ -391,6 +391,21 @@ if (is_linux || is_win) {
}
}
+ config("peerconnection_client_warnings_config") {
+ if (is_win && is_clang) {
+ cflags = [
+ # Disable warnings failing when compiling with Clang on Windows.
+ # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
+ "-Wno-format",
+
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6271
+ # for -Wno-reorder and -Wno-sign-compare
+ "-Wno-reorder",
+ "-Wno-sign-compare",
+ ]
+ }
+ }
+
executable("peerconnection_client") {
sources = [
"peerconnection/client/conductor.cc",
@@ -415,14 +430,6 @@ if (is_linux || is_win) {
cflags = [ "/wd4245" ]
configs += [ "//build/config/win:windowed" ]
}
- if (is_win && is_clang) {
- cflags = [
- # Disable warnings failing when compiling with Clang on Windows.
- # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
- "-Wno-reorder",
- "-Wno-unused-function",
- ]
- }
if (is_linux) {
sources += [
"peerconnection/client/linux/main.cc",
@@ -443,6 +450,7 @@ if (is_linux || is_win) {
"//webrtc/system_wrappers:field_trial_default",
"//webrtc/system_wrappers:metrics_default",
]
+ configs += [ ":peerconnection_client_warnings_config" ]
if (rtc_build_json) {
deps += [ "//third_party/jsoncpp" ]
}
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698