Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: webrtc/media/BUILD.gn

Issue 2281513002: GN: Fix windows clang errors. Attempt 2. (Closed)
Patch Set: Revert mb_config.pyl. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/examples/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/linux/pkg_config.gni") 9 import("//build/config/linux/pkg_config.gni")
10 import("../build/webrtc.gni") 10 import("../build/webrtc.gni")
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 public_deps += [ "//testing/gmock" ] 272 public_deps += [ "//testing/gmock" ]
273 } 273 }
274 274
275 config("rtc_media_unittests_config") { 275 config("rtc_media_unittests_config") {
276 # GN orders flags on a target before flags from configs. The default config 276 # GN orders flags on a target before flags from configs. The default config
277 # adds -Wall, and this flag have to be after -Wall -- so they need to 277 # adds -Wall, and this flag have to be after -Wall -- so they need to
278 # come from a config and can"t be on the target directly. 278 # come from a config and can"t be on the target directly.
279 # TODO(kjellander): Make the code compile without disabling these flags. 279 # TODO(kjellander): Make the code compile without disabling these flags.
280 # See https://bugs.webrtc.org/3307. 280 # See https://bugs.webrtc.org/3307.
281 if (is_clang && is_win) { 281 if (is_clang && is_win) {
282 cflags = [ "-Wno-unused-function" ] 282 cflags = [
283 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=6266
284 # for -Wno-sign-compare
285 "-Wno-sign-compare",
286 "-Wno-unused-function",
287 ]
283 } 288 }
284 if (!is_win) { 289 if (!is_win) {
285 cflags = [ "-Wno-sign-compare" ] 290 cflags = [ "-Wno-sign-compare" ]
286 cflags_cc = [ "-Wno-overloaded-virtual" ] 291 cflags_cc = [ "-Wno-overloaded-virtual" ]
287 } 292 }
288 } 293 }
289 294
290 test("rtc_media_unittests") { 295 test("rtc_media_unittests") {
291 testonly = true 296 testonly = true
292 297
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 deps += [ 366 deps += [
362 # TODO(kjellander): Move as part of work in bugs.webrtc.org/4243. 367 # TODO(kjellander): Move as part of work in bugs.webrtc.org/4243.
363 ":rtc_media", 368 ":rtc_media",
364 ":rtc_unittest_main", 369 ":rtc_unittest_main",
365 "../audio", 370 "../audio",
366 "../base:rtc_base_tests_utils", 371 "../base:rtc_base_tests_utils",
367 "../system_wrappers:metrics_default", 372 "../system_wrappers:metrics_default",
368 ] 373 ]
369 } 374 }
370 } 375 }
OLDNEW
« no previous file with comments | « webrtc/examples/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698