Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2280903002: Remove last_width_/last_height_ from WebRtcVideoReceiveStream. Used in GetStats. Get dimensions fro… (Closed)

Created:
4 years, 3 months ago by åsapersson
Modified:
4 years, 3 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove last_width_/last_height_ from WebRtcVideoReceiveStream. Used in GetStats. Get dimensions from VideoReceiveStream::Stats instead. BUG=webrtc:6274 Committed: https://crrev.com/26dd92b2ff4a4c44488569befdd1d9392b5aea2e Cr-Commit-Position: refs/heads/master@{#13967}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M webrtc/media/engine/webrtcvideoengine2.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
åsapersson
4 years, 3 months ago (2016-08-26 15:33:55 UTC) #3
perkj_webrtc
On 2016/08/26 15:33:55, åsapersson wrote: lgtm A bug number tracking this effort?
4 years, 3 months ago (2016-08-29 06:08:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2280903002/80001
4 years, 3 months ago (2016-08-30 06:39:32 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 3 months ago (2016-08-30 07:45:49 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 07:45:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26dd92b2ff4a4c44488569befdd1d9392b5aea2e
Cr-Commit-Position: refs/heads/master@{#13967}

Powered by Google App Engine
This is Rietveld 408576698