Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: webrtc/api/android/java/src/org/webrtc/VideoSource.java

Issue 2280873002: Remove VideoSource.stop() and VideoSource.restart() from the Java API. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/android/jni/peerconnection_jni.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 11
12 package org.webrtc; 12 package org.webrtc;
13 13
14 /** 14 /**
15 * Java version of VideoSourceInterface, extended with stop/restart 15 * Java version of VideoSourceInterface, extended with stop/restart
16 * functionality to allow explicit control of the camera device on android, 16 * functionality to allow explicit control of the camera device on android,
17 * where there is no support for multiple open capture devices and the cost of 17 * where there is no support for multiple open capture devices and the cost of
18 * holding a camera open (even if MediaStreamTrack.setEnabled(false) is muting 18 * holding a camera open (even if MediaStreamTrack.setEnabled(false) is muting
19 * its output to the encoder) can be too high to bear. 19 * its output to the encoder) can be too high to bear.
20 */ 20 */
21 public class VideoSource extends MediaSource { 21 public class VideoSource extends MediaSource {
22
23 public VideoSource(long nativeSource) { 22 public VideoSource(long nativeSource) {
24 super(nativeSource); 23 super(nativeSource);
25 } 24 }
26
27 // Stop capture feeding this source.
28 public void stop() {
29 stop(nativeSource);
30 }
31
32 // Restart capture feeding this source. stop() must have been called since
33 // the last call to restart() (if any). Note that this isn't "start()";
34 // sources are started by default at birth.
35 public void restart() {
36 restart(nativeSource);
37 }
38
39 private static native void stop(long nativeSource);
40 private static native void restart(long nativeSource);
41 } 25 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/android/jni/peerconnection_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698