Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2280873002: Remove VideoSource.stop() and VideoSource.restart() from the Java API. (Closed)

Created:
4 years, 3 months ago by sakal
Modified:
4 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoSource.stop() and VideoSource.restart() from the Java API. These methods are not used by the new AndroidVideoTrackSource API. Committed: https://crrev.com/4b2be9739b6fff561e2477b9c3b4a47433116ccc Cr-Commit-Position: refs/heads/master@{#14036} BUG=webrtc:6318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M webrtc/api/android/java/src/org/webrtc/VideoSource.java View 1 chunk +0 lines, -16 lines 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sakal
PTAL
4 years, 3 months ago (2016-08-29 07:23:00 UTC) #7
magjed_webrtc
lgtm As a follow-up, can we remove the Restart method from VideoTrackSourceInterface? Not really related, ...
4 years, 3 months ago (2016-08-30 10:58:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2280873002/1
4 years, 3 months ago (2016-09-02 07:20:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 08:09:35 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 08:10:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b2be9739b6fff561e2477b9c3b4a47433116ccc
Cr-Commit-Position: refs/heads/master@{#14036}

Powered by Google App Engine
This is Rietveld 408576698