webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc - Issue 2280703002: Ignore Camera and Flip bits in CVO when parsing video rotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc

Issue 2280703002: Ignore Camera and Flip bits in CVO when parsing video rotation (Closed)

Patch Set: Update unittests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc b/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc

index 2d5dbf91b4d242e2b432fc55d390d808f9b821f6..6e65ed3d8dff5038ce91275df6e1ce666ccfa523 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_header_extensions.cc

@@ -177,7 +177,7 @@ bool VideoOrientation::IsSupportedFor(MediaType type) {

}

bool VideoOrientation::Parse(const uint8_t* data, VideoRotation* rotation) {

- *rotation = ConvertCVOByteToVideoRotation(data[0] & 0x03);

+ *rotation = ConvertCVOByteToVideoRotation(data[0]);

return true;

}