Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 2280633002: Remove GYP execution from DEPS hooks (gclient {sync,runhooks}) (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove GYP execution from DEPS hooks (gclient {sync,runhooks}) Due to the recent roll of chromium_revision in DEPS in https://codereview.webrtc.org/2269953002/ an Android checkout now experiences an error when running GYP (which is automatically done as a hook when you run 'gclient {sync,runhooks}'. This CL removes the GYP invocation entirely, as it would soon be removed anyway as part of the GN migration. All our bots are executing GYP/GN as part of the MB step (called 'generate_build_files'), so they won't be affected. BUG=webrtc:5949, webrtc:6258 NOTRY=True Committed: https://crrev.com/e575c01b9de669e59c63db805bca587c56108dad Cr-Commit-Position: refs/heads/master@{#13920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M DEPS View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 3 months ago (2016-08-25 10:26:29 UTC) #3
ehmaldonado_webrtc
On 2016/08/25 10:26:29, kjellander_webrtc wrote: lgtm
4 years, 3 months ago (2016-08-25 10:57:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2280633002/1
4 years, 3 months ago (2016-08-25 11:14:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 11:22:23 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 11:22:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e575c01b9de669e59c63db805bca587c56108dad
Cr-Commit-Position: refs/heads/master@{#13920}

Powered by Google App Engine
This is Rietveld 408576698