Update AecDump API to match RtcEventLog API signature.

webrtc/examples/objc/AppRTCDemo/ARDAppClient.m

 /*
  *  Copyright 2014 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 40 matching lines @@
 static NSInteger const kARDAppClientErrorInvalidRoom = -6;
 static NSString * const kARDMediaStreamId = @"ARDAMS";
 static NSString * const kARDAudioTrackId = @"ARDAMSa0";
 static NSString * const kARDVideoTrackId = @"ARDAMSv0";
 
 // TODO(tkchin): Remove guard once rtc_sdk_common_objc compiles on Mac.
 #if defined(WEBRTC_IOS)
 // TODO(tkchin): Add these as UI options.
 static BOOL const kARDAppClientEnableTracing = NO;
 static BOOL const kARDAppClientEnableRtcEventLog = YES;
+static int64_t const kARDAppClientAecDumpMaxSizeInBytes = 5e6;  // 5 MB.
 static int64_t const kARDAppClientRtcEventLogMaxSizeInBytes = 5e6;  // 5 MB.
 #endif
 
 // We need a proxy to NSTimer because it causes a strong retain cycle. When
 // using the proxy, |invalidate| must be called before it properly deallocs.
 @interface ARDTimerProxy : NSObject
 
 - (instancetype)initWithInterval:(NSTimeInterval)interval
                          repeats:(BOOL)repeats
                     timerHandler:(void (^)(void))timerHandler;
@@ skipping 52 matching lines @@
 @synthesize clientId = _clientId;
 @synthesize isInitiator = _isInitiator;
 @synthesize iceServers = _iceServers;
 @synthesize webSocketURL = _websocketURL;
 @synthesize webSocketRestURL = _websocketRestURL;
 @synthesize defaultPeerConnectionConstraints =
     _defaultPeerConnectionConstraints;
 @synthesize isLoopback = _isLoopback;
 @synthesize isAudioOnly = _isAudioOnly;
 @synthesize shouldMakeAecDump = _shouldMakeAecDump;
-@synthesize isAecDumpActive = _isAecDumpActive;
 @synthesize shouldUseLevelControl = _shouldUseLevelControl;
 
 - (instancetype)init {
   if (self = [super init]) {
     _roomServerClient = [[ARDAppEngineClient alloc] init];
     NSURL *turnRequestURL = [NSURL URLWithString:kARDTurnRequestUrl];
     _turnClient = [[ARDCEODTURNClient alloc] initWithURL:turnRequestURL];
     [self configure];
   }
   return self;
@@ skipping 165 matching lines @@
     }
     // Disconnect from collider.
     _channel = nil;
   }
   _clientId = nil;
   _roomId = nil;
   _isInitiator = NO;
   _hasReceivedSdp = NO;
   _messageQueue = [NSMutableArray array];
 #if defined(WEBRTC_IOS)
-  if (_isAecDumpActive) {
-    [_factory stopAecDump];
-    _isAecDumpActive = NO;
-  }
+  [_factory stopAecDump];
   [_peerConnection stopRtcEventLog];
 #endif
   _peerConnection = nil;
   self.state = kARDAppClientStateDisconnected;
 #if defined(WEBRTC_IOS)
   RTCStopInternalCapture();
 #endif
 }
 
 #pragma mark - ARDSignalingChannelDelegate
@@ skipping 236 matching lines @@
   if (kARDAppClientEnableRtcEventLog) {
     NSString *filePath = [self documentsFilePathForFileName:@"webrtc-rtceventlog"];
     if (![_peerConnection startRtcEventLogWithFilePath:filePath
                                  maxSizeInBytes:kARDAppClientRtcEventLogMaxSizeInBytes]) {
       RTCLogError(@"Failed to start event logging.");
     }
   }
 
   // Start aecdump diagnostic recording.
   if (_shouldMakeAecDump) {
-    _isAecDumpActive = YES;
-    NSString *filePath = [self documentsFilePathForFileName:@"audio.aecdump"];
-    int fd = open(filePath.UTF8String, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR);
-    if (fd < 0) {
-      RTCLogError(@"Failed to create the aecdump file!");
-      _isAecDumpActive = NO;
-    } else {
-      if (![_factory startAecDumpWithFileDescriptor:fd maxFileSizeInBytes:-1]) {
-        RTCLogError(@"Failed to create aecdump.");
-        _isAecDumpActive = NO;
-      }
+    NSString *filePath = [self documentsFilePathForFileName:@"webrtc-audio.aecdump"];
+    if (![_factory startAecDumpWithFilePath:filePath
+                             maxSizeInBytes:kARDAppClientAecDumpMaxSizeInBytes]) {
+      RTCLogError(@"Failed to start aec dump.");
     }
   }
 #endif
 }
 
 // Processes the messages that we've received from the room server and the
 // signaling channel. The offer or answer message must be processed before other
 // signaling messages, however they can arrive out of order. Hence, this method
 // only processes pending messages if there is a peer connection object and
 // if we have received either an offer or answer.
@@ skipping 254 matching lines @@
                                          code:kARDAppClientErrorInvalidRoom
                                      userInfo:@{
         NSLocalizedDescriptionKey: @"Invalid room.",
       }];
       break;
   }
   return error;
 }
 
 @end