Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2279293003: Update AecDump API to match RtcEventLog API signature. (Closed)

Created:
4 years, 3 months ago by tkchin_webrtc
Modified:
4 years, 3 months ago
Reviewers:
Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update AecDump API to match RtcEventLog API signature. This will ease Swift interop. NOTRY=True BUG= Committed: https://crrev.com/fce0e2c2f6c2e16e73043af210b0fbb1641e0835 Cr-Commit-Position: refs/heads/master@{#13978}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -38 lines) Patch
M webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 1 4 chunks +6 lines, -16 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ARDAppClient+Internal.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 1 2 3 chunks +25 lines, -13 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h View 1 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tkchin_webrtc
4 years, 3 months ago (2016-08-26 23:25:38 UTC) #3
tkchin_webrtc
On 2016/08/26 23:25:38, tkchin_webrtc wrote: ping
4 years, 3 months ago (2016-08-30 18:26:11 UTC) #4
Chuck
lgtm
4 years, 3 months ago (2016-08-30 18:37:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2279293003/40001
4 years, 3 months ago (2016-08-30 19:56:59 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-30 19:58:14 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 19:58:22 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fce0e2c2f6c2e16e73043af210b0fbb1641e0835
Cr-Commit-Position: refs/heads/master@{#13978}

Powered by Google App Engine
This is Rietveld 408576698