Move MutableDataY{,U,V} methods to I420Buffer only.

webrtc/common_video/video_frame.cc

Index: webrtc/common_video/video_frame.cc
diff --git a/webrtc/common_video/video_frame.cc b/webrtc/common_video/video_frame.cc
index b1721b4bc4a1963f06c3824e6b80692bb0e1e0e6..7b8af4bfe38bd6fc935f40d54eb87b9e05c3e530 100644
--- a/webrtc/common_video/video_frame.cc
+++ b/webrtc/common_video/video_frame.cc
@@ -78,10 +78,18 @@ void VideoFrame::CreateFrame(const uint8_t* buffer_y,
   const int expected_size_y = height * stride_y;
   const int expected_size_u = half_height * stride_u;
   const int expected_size_v = half_height * stride_v;
-  CreateEmptyFrame(width, height, stride_y, stride_u, stride_v);

[perkj_webrtc, 2016/09/13 15:29:22]

Remove CreateEmptyFrame?

[nisse-webrtc, 2016/09/14 06:59:05]

I do want to remove CreateEmptyFrame. And the default constructor (they're often
used together) and IsZeroSize. But it's going to be a bit easier after these
changes are landed, it seems it reduces the number of CreateEmptyFrame calls
from 41 to 15.

-  memcpy(video_frame_buffer_->MutableDataY(), buffer_y, expected_size_y);
-  memcpy(video_frame_buffer_->MutableDataU(), buffer_u, expected_size_u);
-  memcpy(video_frame_buffer_->MutableDataV(), buffer_v, expected_size_v);
+  // Allocate a new buffer.
+  rtc::scoped_refptr<I420Buffer> buffer_ =
+      I420Buffer::Create(width, height, stride_y, stride_u, stride_v);
+
+  memcpy(buffer_->MutableDataY(), buffer_y, expected_size_y);
+  memcpy(buffer_->MutableDataU(), buffer_u, expected_size_u);
+  memcpy(buffer_->MutableDataV(), buffer_v, expected_size_v);
+
+  video_frame_buffer_ = buffer_;
+  timestamp_ = 0;
+  ntp_time_ms_ = 0;
+  render_time_ms_ = 0;
   rotation_ = rotation;
 }