Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2278723004: Add missing "//build/config/sanitizers:deps" to executable targets. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add missing "//build/config/sanitizers:deps" to executable targets. BUG=webrtc:6215 NOTRY=True Committed: https://crrev.com/19319a3a2e728030332a3e2cb81e59005e1a5bd0 Cr-Commit-Position: refs/heads/master@{#13915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/tools/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-08-25 08:12:10 UTC) #2
kjellander_webrtc
Thanks, at least things like this goes away as soon we've flipped Linux. lgtm
4 years, 3 months ago (2016-08-25 08:15:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2278723004/1
4 years, 3 months ago (2016-08-25 09:14:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 09:44:05 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 09:44:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19319a3a2e728030332a3e2cb81e59005e1a5bd0
Cr-Commit-Position: refs/heads/master@{#13915}

Powered by Google App Engine
This is Rietveld 408576698