Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: webrtc/stats/rtcstatsreport.cc

Issue 2278433003: RTCStatsReport: Take ownership of other's stats with TakeMembersFrom (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Added comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/stats/rtcstats_unittest.cc ('k') | webrtc/stats/rtcstatsreport_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } 59 }
60 60
61 RTCStatsReport::~RTCStatsReport() { 61 RTCStatsReport::~RTCStatsReport() {
62 } 62 }
63 63
64 bool RTCStatsReport::AddStats(std::unique_ptr<const RTCStats> stats) { 64 bool RTCStatsReport::AddStats(std::unique_ptr<const RTCStats> stats) {
65 return !stats_.insert(std::make_pair(std::string(stats->id()), 65 return !stats_.insert(std::make_pair(std::string(stats->id()),
66 std::move(stats))).second; 66 std::move(stats))).second;
67 } 67 }
68 68
69 const RTCStats* RTCStatsReport::operator[](const std::string& id) const { 69 const RTCStats* RTCStatsReport::Get(const std::string& id) const {
70 StatsMap::const_iterator it = stats_.find(id); 70 StatsMap::const_iterator it = stats_.find(id);
71 if (it != stats_.cend()) 71 if (it != stats_.cend())
72 return it->second.get(); 72 return it->second.get();
73 return nullptr; 73 return nullptr;
74 } 74 }
75 75
76 void RTCStatsReport::TakeMembersFrom(
77 rtc::scoped_refptr<RTCStatsReport> victim) {
78 for (StatsMap::iterator it = victim->stats_.begin();
79 it != victim->stats_.end(); ++it) {
80 AddStats(std::unique_ptr<const RTCStats>(it->second.release()));
81 }
82 victim->stats_.clear();
83 }
84
76 RTCStatsReport::ConstIterator RTCStatsReport::begin() const { 85 RTCStatsReport::ConstIterator RTCStatsReport::begin() const {
77 return ConstIterator(rtc::scoped_refptr<const RTCStatsReport>(this), 86 return ConstIterator(rtc::scoped_refptr<const RTCStatsReport>(this),
78 stats_.cbegin()); 87 stats_.cbegin());
79 } 88 }
80 89
81 RTCStatsReport::ConstIterator RTCStatsReport::end() const { 90 RTCStatsReport::ConstIterator RTCStatsReport::end() const {
82 return ConstIterator(rtc::scoped_refptr<const RTCStatsReport>(this), 91 return ConstIterator(rtc::scoped_refptr<const RTCStatsReport>(this),
83 stats_.cend()); 92 stats_.cend());
84 } 93 }
85 94
86 } // namespace webrtc 95 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/stats/rtcstats_unittest.cc ('k') | webrtc/stats/rtcstatsreport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698