Suppress memcheck errors on linux bot.

Suppress memcheck errors on linux bot.

BUG=

Committed: https://crrev.com/c07c8bb6264d89e01c597b864b1fc5f50b88b73b
Cr-Commit-Position: refs/heads/master@{#13932}

[philipel, 2016-08-25 15:17:15]

philipel@webrtc.org changed reviewers:
+ ehmaldonado@webrtc.org, kjellander@webrtc.org

[philipel, 2016-08-25 15:17:16]

I guess this is the suppresion we need. I'm currently running tests locally but
expect them to be done in ~40 minutes.

[kjellander_webrtc, 2016-08-26 08:04:08]

This should be sufficient yes.
lgtm

https://codereview.webrtc.org/2278183002/diff/1/tools/valgrind-webrtc/memchec...
File tools/valgrind-webrtc/memcheck/suppressions.txt (right):

https://codereview.webrtc.org/2278183002/diff/1/tools/valgrind-webrtc/memchec...
tools/valgrind-webrtc/memcheck/suppressions.txt:267: vfprintf
Yes, this suppression matches the two listed in
https://uberchromegw.corp.google.com/i/tryserver.webrtc/builders/linux_memche...

[kjellander_webrtc, 2016-08-26 08:05:18]

On 2016/08/26 08:04:08, kjellander_webrtc wrote:
> This should be sufficient yes.
> lgtm
> 
>
https://codereview.webrtc.org/2278183002/diff/1/tools/valgrind-webrtc/memchec...
> File tools/valgrind-webrtc/memcheck/suppressions.txt (right):
> 
>
https://codereview.webrtc.org/2278183002/diff/1/tools/valgrind-webrtc/memchec...
> tools/valgrind-webrtc/memcheck/suppressions.txt:267: vfprintf
> Yes, this suppression matches the two listed in
>
https://uberchromegw.corp.google.com/i/tryserver.webrtc/builders/linux_memche...

Add something in CL description about that this is needed for the trybot to go
green (errors not happening on the bot in the main waterfall).

[kjellander_webrtc, 2016-08-26 08:09:02]

https://codereview.webrtc.org/2278183002/diff/1/tools/valgrind-webrtc/memchec...
File tools/valgrind-webrtc/memcheck/suppressions.txt (right):

https://codereview.webrtc.org/2278183002/diff/1/tools/valgrind-webrtc/memchec...
tools/valgrind-webrtc/memcheck/suppressions.txt:269: ...
Actually, add
   fun:vfprintf
   fun:vsnprintf
   fun:snprintf
before the ... wildcard will make the suppression more precise.

[philipel, 2016-08-26 08:16:08]

kjellander@, PTAL

[kjellander_webrtc, 2016-08-26 08:35:30]

You need to restore the lines after ... now (but keep the new ones before).

https://codereview.webrtc.org/2278183002/diff/20001/tools/valgrind-webrtc/mem...
File tools/valgrind-webrtc/memcheck/suppressions.txt (right):

https://codereview.webrtc.org/2278183002/diff/20001/tools/valgrind-webrtc/mem...
tools/valgrind-webrtc/memcheck/suppressions.txt:272: ...
You have to keep the rest of the stuff after ... unchanged (i.e. as in PS#1).

[philipel, 2016-08-26 09:25:38]

Fixed the fix, PTAL

[kjellander_webrtc, 2016-08-26 10:33:09]

lgtm

[philipel, 2016-08-26 11:06:54]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2016-08-26 11:07:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kjellander_webrtc, 2016-08-26 11:39:54]

On 2016/08/26 11:07:06, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

Argh. Should use NOTRY=True on these.

I hope we get time to implement some intelligence regarding analyzing patches
sometime soon. Chrome infra has such, but we're not using it.

[commit-bot: I haz the power, 2016-08-26 12:28:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-26 12:28:50]

Description was changed from

==========
Suppress memcheck errors on linux bot.

BUG=
==========

to

==========
Suppress memcheck errors on linux bot.

BUG=

Committed: https://crrev.com/c07c8bb6264d89e01c597b864b1fc5f50b88b73b
Cr-Commit-Position: refs/heads/master@{#13932}
==========

[commit-bot: I haz the power, 2016-08-26 12:28:51]

Patchset 3 (id:??) landed as
https://crrev.com/c07c8bb6264d89e01c597b864b1fc5f50b88b73b
Cr-Commit-Position: refs/heads/master@{#13932}