Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2277753003: GN: Synchronize resources between Android and iOS. (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Synchronize resources between Android and iOS. iOS tests packaged into an .app uses the same way of defining resources (the data attribute). Some iOS simulator tests are failing due to missing resources, so let's sync them all. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/28a0ffdd52d9ea0063c8344881f909832796e1e0 Cr-Commit-Position: refs/heads/master@{#13898}

Patch Set 1 #

Patch Set 2 : Removed outdated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M webrtc/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/common_video/BUILD.gn View 1 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
This should fix at least the iOS simulator bots.
4 years, 4 months ago (2016-08-24 13:43:52 UTC) #3
ehmaldonado_webrtc
On 2016/08/24 13:43:52, kjellander_webrtc wrote: > This should fix at least the iOS simulator bots. ...
4 years, 4 months ago (2016-08-24 13:59:30 UTC) #4
kjellander_webrtc
On 2016/08/24 13:59:30, ehmaldonado_webrtc wrote: > On 2016/08/24 13:43:52, kjellander_webrtc wrote: > > This should ...
4 years, 4 months ago (2016-08-24 14:38:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2277753003/20001
4 years, 4 months ago (2016-08-24 14:39:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 14:48:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 14:48:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28a0ffdd52d9ea0063c8344881f909832796e1e0
Cr-Commit-Position: refs/heads/master@{#13898}

Powered by Google App Engine
This is Rietveld 408576698