Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2277633004: Relax expectation in EndToEndTest.CallReportsRttForSender test (Closed)

Created:
4 years, 3 months ago by danilchap
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman, Taylor Brandstetter
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relax expectation in EndToEndTest.CallReportsRttForSender test to reduce flakiness by ignoring potentional rounding errors and minor ntp time adjustments. BUG=webrtc:5938 R=deadbeef@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/10e8f8e2a4e17a24f4b17e38b7e6c87e879e1b96 Cr-Commit-Position: refs/heads/master@{#14104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/video/end_to_end_tests.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
4 years, 3 months ago (2016-08-25 12:32:33 UTC) #3
Taylor Brandstetter
Not an owner, but lgtm.
4 years, 3 months ago (2016-08-25 17:20:21 UTC) #5
stefan-webrtc
lgtm
4 years, 3 months ago (2016-09-07 13:03:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/10e8f8e2a4e17a24f4b17e38b7e6c87e879e1b96 Cr-Commit-Position: refs/heads/master@{#14104}
4 years, 3 months ago (2016-09-07 13:05:49 UTC) #9
danilchap
4 years, 3 months ago (2016-09-07 13:05:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10e8f8e2a4e17a24f4b17e38b7e6c87e879e1b96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698