Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2277253002: MB: Flip Windows bots to GN by default (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Flip Windows bots to GN by default Change the previous GN configs to build GYP instead (since we'll keep GYP around for a while) but exclude tests and examples for that config, since we'll only support the production code for GYP. Add new configs for upcoming rename of those bots to GYP instead of GN. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/133edb2131954837f8b6877f9941e70b8f1f6746 Cr-Commit-Position: refs/heads/master@{#13946}

Patch Set 1 #

Patch Set 2 : Rebased after Linux flip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -60 lines) Patch
M webrtc/build/mb_config.pyl View 1 5 chunks +59 lines, -60 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kjellander_webrtc
Dr Memory Full is going to take long... I might skip waiting for that one.
4 years, 3 months ago (2016-08-25 12:21:02 UTC) #2
ehmaldonado_webrtc
On 2016/08/25 12:21:02, kjellander_webrtc wrote: > Dr Memory Full is going to take long... I ...
4 years, 3 months ago (2016-08-27 05:18:44 UTC) #3
kjellander_webrtc
On 2016/08/27 05:18:44, ehmaldonado_webrtc wrote: > On 2016/08/25 12:21:02, kjellander_webrtc wrote: > > Dr Memory ...
4 years, 3 months ago (2016-08-29 03:08:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2277253002/1
4 years, 3 months ago (2016-08-29 03:08:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7776)
4 years, 3 months ago (2016-08-29 03:24:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2277253002/20001
4 years, 3 months ago (2016-08-29 03:28:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-29 03:36:01 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 03:36:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/133edb2131954837f8b6877f9941e70b8f1f6746
Cr-Commit-Position: refs/heads/master@{#13946}

Powered by Google App Engine
This is Rietveld 408576698