Cleaning up existing chromium.perf.json. Alphabetizing

Cleaning up existing chromium.perf.json.  Alphabetizing
and removing bots not longer on the waterfall.

This is to prepare for auto generation of this file in
 https://codereview.chromium.org/2272603005/.

Note this does not attempt to do any refactoring of what
shards these tests are run on etc, it is only cleanup. That will
be saved for a follow on task.

BUG=chromium:633253
Committed: https://crrev.com/ae706b00484053b65240143bb4c533e55ac1ad4b
Cr-Commit-Position: refs/heads/master@{#414496}

[eyaich1, 2016-08-25 12:59:33]

eyaich@chromium.org changed reviewers:
+ dtu@chromium.org

[dtu, 2016-08-25 15:59:58]

The current behavior for Win 7 Intel GPU Perf is not that it runs on all the
shards, but that it runs on none of them.

[eyaich1, 2016-08-25 16:07:00]

On 2016/08/25 15:59:58, dtu wrote:
> The current behavior for Win 7 Intel GPU Perf is not that it runs on all the
> shards, but that it runs on none of them.

This generated dict for the chromium.perf.json shows it on all 5 shards though. 


https://paste.googleplex.com/6131461237243904

If it was running on none, why would it be included in the JSON file at all? 
There is no where that we tell it to ignore it.  Can you clarify?

[dtu, 2016-08-25 16:16:35]

On 2016/08/25 16:07:00, eyaich1 wrote:
> On 2016/08/25 15:59:58, dtu wrote:
> > The current behavior for Win 7 Intel GPU Perf is not that it runs on all the
> > shards, but that it runs on none of them.
> 
> This generated dict for the chromium.perf.json shows it on all 5 shards
though. 
> 
> 
> https://paste.googleplex.com/6131461237243904

That dict isn't generated from chromium.perf.json. It's generated entirely
within recipe_modules/chromium_tests/chromium_perf.py.

> If it was running on none, why would it be included in the JSON file at all? 
> There is no where that we tell it to ignore it.  Can you clarify?

I think it's a historical artifact, similar to those other nonexistent bots.
Originally, we only had one "Win 7 Intel GPU Perf" bot with that exact name.
When we added the shards for it, we didn't update chromium.perf.json. So the
script tests stopped running and nobody noticed.

[eyaich1, 2016-08-25 16:22:37]

On 2016/08/25 16:16:35, dtu wrote:
> On 2016/08/25 16:07:00, eyaich1 wrote:
> > On 2016/08/25 15:59:58, dtu wrote:
> > > The current behavior for Win 7 Intel GPU Perf is not that it runs on all
the
> > > shards, but that it runs on none of them.
> > 
> > This generated dict for the chromium.perf.json shows it on all 5 shards
> though. 
> > 
> > 
> > https://paste.googleplex.com/6131461237243904
> 
> That dict isn't generated from chromium.perf.json. It's generated entirely
> within recipe_modules/chromium_tests/chromium_perf.py.
> 
> > If it was running on none, why would it be included in the JSON file at all?

> > There is no where that we tell it to ignore it.  Can you clarify?
> 
> I think it's a historical artifact, similar to those other nonexistent bots.
> Originally, we only had one "Win 7 Intel GPU Perf" bot with that exact name.
> When we added the shards for it, we didn't update chromium.perf.json. So the
> script tests stopped running and nobody noticed.

Ok so should I add it back in on shard 1 or just drop it?

[dtu, 2016-08-25 16:30:08]

On 2016/08/25 16:22:37, eyaich1 wrote:
> On 2016/08/25 16:16:35, dtu wrote:
> > On 2016/08/25 16:07:00, eyaich1 wrote:
> > > On 2016/08/25 15:59:58, dtu wrote:
> > > > The current behavior for Win 7 Intel GPU Perf is not that it runs on all
> the
> > > > shards, but that it runs on none of them.
> > > 
> > > This generated dict for the chromium.perf.json shows it on all 5 shards
> > though. 
> > > 
> > > 
> > > https://paste.googleplex.com/6131461237243904
> > 
> > That dict isn't generated from chromium.perf.json. It's generated entirely
> > within recipe_modules/chromium_tests/chromium_perf.py.
> > 
> > > If it was running on none, why would it be included in the JSON file at
all?
> 
> > > There is no where that we tell it to ignore it.  Can you clarify?
> > 
> > I think it's a historical artifact, similar to those other nonexistent bots.
> > Originally, we only had one "Win 7 Intel GPU Perf" bot with that exact name.
> > When we added the shards for it, we didn't update chromium.perf.json. So the
> > script tests stopped running and nobody noticed.
> 
> Ok so should I add it back in on shard 1 or just drop it?

You were going to do the resharding after the script CL, right? So for this CL,
retain the existing behavior by dropping it.

[eyaich1, 2016-08-25 16:33:36]

On 2016/08/25 16:30:08, dtu wrote:
> On 2016/08/25 16:22:37, eyaich1 wrote:
> > On 2016/08/25 16:16:35, dtu wrote:
> > > On 2016/08/25 16:07:00, eyaich1 wrote:
> > > > On 2016/08/25 15:59:58, dtu wrote:
> > > > > The current behavior for Win 7 Intel GPU Perf is not that it runs on
all
> > the
> > > > > shards, but that it runs on none of them.
> > > > 
> > > > This generated dict for the chromium.perf.json shows it on all 5 shards
> > > though. 
> > > > 
> > > > 
> > > > https://paste.googleplex.com/6131461237243904
> > > 
> > > That dict isn't generated from chromium.perf.json. It's generated entirely
> > > within recipe_modules/chromium_tests/chromium_perf.py.
> > > 
> > > > If it was running on none, why would it be included in the JSON file at
> all?
> > 
> > > > There is no where that we tell it to ignore it.  Can you clarify?
> > > 
> > > I think it's a historical artifact, similar to those other nonexistent
bots.
> > > Originally, we only had one "Win 7 Intel GPU Perf" bot with that exact
name.
> > > When we added the shards for it, we didn't update chromium.perf.json. So
the
> > > script tests stopped running and nobody noticed.
> > 
> > Ok so should I add it back in on shard 1 or just drop it?
> 
> You were going to do the resharding after the script CL, right? So for this
CL,
> retain the existing behavior by dropping it.

Done

[dtu, 2016-08-25 16:34:19]

lgtm

[eyaich1, 2016-08-25 16:34:50]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:35:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 16:43:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 16:43:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sullivan, 2016-08-25 17:06:00]

sullivan@chromium.org changed reviewers:
+ sullivan@chromium.org

[sullivan, 2016-08-25 17:06:01]

lgtm

[eyaich1, 2016-08-25 17:06:39]

Description was changed from

==========
Cleaning up existing chromium.perf.json.  Alphabetizing
and removing bots not longer on the waterfall.

This is to prepare for auto generation of this file in
 https://codereview.chromium.org/2272603005/.

Note this does not attempt to do any refactoring of what
shards these tests are run on etc, it is only cleanup. That will
be saved for a follow on task.

BUG=chromium:633253
==========

to

==========
Cleaning up existing chromium.perf.json.  Alphabetizing
and removing bots not longer on the waterfall.

This is to prepare for auto generation of this file in
 https://codereview.chromium.org/2272603005/.

Note this does not attempt to do any refactoring of what
shards these tests are run on etc, it is only cleanup. That will
be saved for a follow on task.

BUG=chromium:633253
==========

[eyaich1, 2016-08-25 17:06:47]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-08-25 17:07:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:58:19]

Description was changed from

==========
Cleaning up existing chromium.perf.json.  Alphabetizing
and removing bots not longer on the waterfall.

This is to prepare for auto generation of this file in
 https://codereview.chromium.org/2272603005/.

Note this does not attempt to do any refactoring of what
shards these tests are run on etc, it is only cleanup. That will
be saved for a follow on task.

BUG=chromium:633253
==========

to

==========
Cleaning up existing chromium.perf.json.  Alphabetizing
and removing bots not longer on the waterfall.

This is to prepare for auto generation of this file in
 https://codereview.chromium.org/2272603005/.

Note this does not attempt to do any refactoring of what
shards these tests are run on etc, it is only cleanup. That will
be saved for a follow on task.

BUG=chromium:633253
==========

[commit-bot: I haz the power, 2016-08-25 18:58:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 19:03:00]

Description was changed from

==========
Cleaning up existing chromium.perf.json.  Alphabetizing
and removing bots not longer on the waterfall.

This is to prepare for auto generation of this file in
 https://codereview.chromium.org/2272603005/.

Note this does not attempt to do any refactoring of what
shards these tests are run on etc, it is only cleanup. That will
be saved for a follow on task.

BUG=chromium:633253
==========

to

==========
Cleaning up existing chromium.perf.json.  Alphabetizing
and removing bots not longer on the waterfall.

This is to prepare for auto generation of this file in
 https://codereview.chromium.org/2272603005/.

Note this does not attempt to do any refactoring of what
shards these tests are run on etc, it is only cleanup. That will
be saved for a follow on task.

BUG=chromium:633253

Committed: https://crrev.com/ae706b00484053b65240143bb4c533e55ac1ad4b
Cr-Commit-Position: refs/heads/master@{#414496}
==========

[commit-bot: I haz the power, 2016-08-25 19:03:01]

Patchset 3 (id:??) landed as
https://crrev.com/ae706b00484053b65240143bb4c533e55ac1ad4b
Cr-Commit-Position: refs/heads/master@{#414496}