Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2276933002: Added more targets to .gn. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@real_master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added more targets to .gn. NOTRY=True Committed: https://crrev.com/5f2e7c4097a43487e5928ef35f340228f18d635a Cr-Commit-Position: refs/heads/master@{#13896}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
aleloi
Ptal!
4 years, 4 months ago (2016-08-24 12:04:49 UTC) #2
kjellander_webrtc
lgtm, I added NOTRY=True for you.
4 years, 4 months ago (2016-08-24 13:40:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2276933002/20001
4 years, 4 months ago (2016-08-24 13:46:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-24 13:55:02 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:55:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f2e7c4097a43487e5928ef35f340228f18d635a
Cr-Commit-Position: refs/heads/master@{#13896}

Powered by Google App Engine
This is Rietveld 408576698