Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2275973003: Disable examples for GYP Android bots. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable examples for GYP Android bots. When rolling Chromium into WebRTC, these fail to compile since chromium no longer supports GYP. BUG=webrtc:6252 NOTRY=True Committed: https://crrev.com/7a0ff2f700f81dfe2e5fac2d53b01a4c8f413f81 Cr-Commit-Position: refs/heads/master@{#13892}

Patch Set 1 : Revert DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M webrtc/build/mb_config.pyl View 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ehmaldonado_webrtc
4 years, 4 months ago (2016-08-24 12:53:06 UTC) #4
kjellander_webrtc
lgtm, thanks for sorting my exclude_tests mixin :)
4 years, 4 months ago (2016-08-24 12:56:43 UTC) #5
ehmaldonado_webrtc
On 2016/08/24 12:56:43, kjellander_webrtc wrote: > lgtm, thanks for sorting my exclude_tests mixin :) :)
4 years, 4 months ago (2016-08-24 13:01:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2275973003/20001
4 years, 4 months ago (2016-08-24 13:01:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-24 13:09:21 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 13:09:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a0ff2f700f81dfe2e5fac2d53b01a4c8f413f81
Cr-Commit-Position: refs/heads/master@{#13892}

Powered by Google App Engine
This is Rietveld 408576698