Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: webrtc/media/base/videoframe.h

Issue 2275313003: Revert of Delete method cricket::VideoFrame::Copy. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/android/jni/peerconnection_jni.cc ('k') | webrtc/media/base/videoframe_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videoframe.h
diff --git a/webrtc/media/base/videoframe.h b/webrtc/media/base/videoframe.h
index 3dcbb4efa5150341ac5106b92e18d3709bcde3f6..a1393499f9e72742ba5792e790c09cf5fe52baf5 100644
--- a/webrtc/media/base/videoframe.h
+++ b/webrtc/media/base/videoframe.h
@@ -58,6 +58,16 @@
// Indicates the rotation angle in degrees.
virtual webrtc::VideoRotation rotation() const = 0;
+ // Make a shallow copy of the frame. The frame buffer itself is not copied.
+ // Both the current and new VideoFrame will share a single reference-counted
+ // frame buffer.
+
+ // TODO(nisse): Deprecated, to be deleted in the cricket::VideoFrame and
+ // webrtc::VideoFrame merge. To make a copy, use the cricket::WebRtcVideoFrame
+ // constructor passing video_frame_buffer(), rotation() and timestamp_us() as
+ // arguments.
+ virtual VideoFrame *Copy() const = 0;
+
// Return a copy of frame which has its pending rotation applied. The
// ownership of the returned frame is held by this frame.
« no previous file with comments | « webrtc/api/android/jni/peerconnection_jni.cc ('k') | webrtc/media/base/videoframe_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698