Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2275313003: Revert of Delete method cricket::VideoFrame::Copy. (Closed)

Created:
4 years, 3 months ago by philipel
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete method cricket::VideoFrame::Copy. (patchset #3 id:210001 of https://codereview.webrtc.org/2275243002/ ) Reason for revert: Again, brakes a downstream build by removing VideoFrame::Copy method. Original issue's description: > Reland of Delete method cricket::VideoFrame::Copy. (patchset #1 id:1 of https://codereview.webrtc.org/2087923004/ ) > > Reason for revert: > Downstream issue now fixed. > > Original issue's description: > > Revert of Delete method cricket::VideoFrame::Copy. (patchset #7 id:120001 of https://codereview.webrtc.org/2080253002/ ) > > > > Reason for revert: > > It broke a downstream build by removing VideoFrame::Copy method. > > > > Original issue's description: > > > Delete method cricket::VideoFrame::Copy. > > > > > > Should be unused in Chrome since cl > > > https://codereview.chromium.org/2068703002/ > > > > > > TBR=tkchin@webrtc.org,magjed@webrtc.org > > > BUG=webrtc:5682 > > > > > > Committed: https://crrev.com/9c00f646f0b3cd33506a1944c7bc6724af041237 > > > Committed: https://crrev.com/7e4e00d189a5dfac2b463a5100ee65ee2f11ed79 > > > Cr-Original-Commit-Position: refs/heads/master@{#13236} > > > Cr-Commit-Position: refs/heads/master@{#13244} > > > > TBR=pbos@webrtc.org,tkchin@webrtc.org,magjed@webrtc.org,sergeyu@chromium.org,nisse@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/123f33cd009606d22cca8b0f4756812406d4580f > > Cr-Commit-Position: refs/heads/master@{#13246} > > TBR=pbos@webrtc.org,tkchin@webrtc.org,magjed@webrtc.org,sergeyu@chromium.org,honghaiz@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5682 > > Committed: https://crrev.com/f715f983f1b33208ab2d2434f8b36ad5271f680f > Cr-Commit-Position: refs/heads/master@{#13924} TBR=pbos@webrtc.org,tkchin@webrtc.org,magjed@webrtc.org,sergeyu@chromium.org,honghaiz@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Committed: https://crrev.com/91b03b0ff8c480e4245835c7a4a93733aac534a6 Cr-Commit-Position: refs/heads/master@{#13925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M talk/app/webrtc/objc/RTCI420Frame.mm View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/media/base/videoframe.h View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 1 chunk +25 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipel
Created Revert of Delete method cricket::VideoFrame::Copy.
4 years, 3 months ago (2016-08-25 14:07:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2275313003/1
4 years, 3 months ago (2016-08-25 14:08:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 14:08:19 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/91b03b0ff8c480e4245835c7a4a93733aac534a6 Cr-Commit-Position: refs/heads/master@{#13925}
4 years, 3 months ago (2016-08-25 14:08:24 UTC) #6
nisse-webrtc
4 years, 3 months ago (2016-08-29 06:49:53 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2287223002/ by nisse@webrtc.org.

The reason for reverting is: Fixed downstream issue..

Powered by Google App Engine
This is Rietveld 408576698