webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h - Issue 2275303003: Reorder member functions in FecReceiver unit test. (pt. 10)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/modules/rtp_rtcp/source/fec_receiver_impl.h

Issue 2275303003: Reorder member functions in FecReceiver unit test. (pt. 10) (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@add_flexfec_packet_generator_test_helper

Patch Set: Fix. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/modules/rtp_rtcp/include/fec_receiver.h ('k') | webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc » ('j') | webrtc/modules/rtp_rtcp/source/fec_receiver_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 28 matching lines...) Expand all Loading...
39 rtc::CriticalSection crit_sect_;	39 rtc::CriticalSection crit_sect_;

40 RtpData* recovered_packet_callback_;	40 RtpData* recovered_packet_callback_;

41 std::unique_ptr<ForwardErrorCorrection> fec_;	41 std::unique_ptr<ForwardErrorCorrection> fec_;

42 // TODO(holmer): In the current version \|received_packets_\| is never more	42 // TODO(holmer): In the current version \|received_packets_\| is never more

43 // than one packet, since we process FEC every time a new packet	43 // than one packet, since we process FEC every time a new packet

44 // arrives. We should remove the list.	44 // arrives. We should remove the list.

45 ForwardErrorCorrection::ReceivedPacketList received_packets_;	45 ForwardErrorCorrection::ReceivedPacketList received_packets_;

46 ForwardErrorCorrection::RecoveredPacketList recovered_packets_;	46 ForwardErrorCorrection::RecoveredPacketList recovered_packets_;

47 FecPacketCounter packet_counter_;	47 FecPacketCounter packet_counter_;

48 };	48 };

	49
	philipel 2016/09/05 13:55:58 Oops? Oops? brandtr 2016/09/05 14:38:48 Intended (for symmetry!) :) Didn't make it to the Show quoted text On 2016/09/05 13:55:58, philipel wrote: > Oops? Intended (for symmetry!) :) Didn't make it to the commit message though.
49 } // namespace webrtc	50 } // namespace webrtc

50	51

51 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_FEC_RECEIVER_IMPL_H_	52 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_FEC_RECEIVER_IMPL_H_

OLD	NEW