Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2274883002: GN: Override lsan and tsan suppression files. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_webrtc
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Override lsan and tsan suppression files. BUG=webrtc:6236 NOTRY=True Committed: https://crrev.com/2df32a31d2998578a7824ede864f1e4e9db8ec6b Cr-Commit-Position: refs/heads/master@{#13897}

Patch Set 1 #

Patch Set 2 : Simulate chromium roll. #

Patch Set 3 : Revert 'Simulate chromium roll.' changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build_overrides/build.gni View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ehmaldonado_webrtc
4 years, 4 months ago (2016-08-24 14:16:52 UTC) #3
ehmaldonado_webrtc
On 2016/08/24 14:16:52, ehmaldonado_webrtc wrote: Libfuzzer is using GN, so we have to commit this ...
4 years, 4 months ago (2016-08-24 14:17:17 UTC) #4
kjellander_webrtc
Not sure why you have to commit this beforehand since libfuzzer doesn't use the sanitizers ...
4 years, 4 months ago (2016-08-24 14:34:09 UTC) #5
kjellander_webrtc
On 2016/08/24 14:34:09, kjellander_webrtc wrote: > Not sure why you have to commit this beforehand ...
4 years, 4 months ago (2016-08-24 14:34:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2274883002/40001
4 years, 4 months ago (2016-08-24 14:37:38 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 14:46:15 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 14:46:24 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2df32a31d2998578a7824ede864f1e4e9db8ec6b
Cr-Commit-Position: refs/heads/master@{#13897}

Powered by Google App Engine
This is Rietveld 408576698