Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2274813004: Revert of GN build rules for four audio processing test executables (Closed)

Created:
4 years, 4 months ago by sakal
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1, aleloi, ivoc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of GN build rules for four audio processing test executables (patchset #3 id:40001 of https://codereview.webrtc.org/2267403003/ ) Reason for revert: Breaks most of the chromium.webrtc.fyi bots. Original issue's description: > GN build rules for four audio processing test executables > > click_annotate, intelligibility_proc, nonlinear_beamformer_test, and > transient_suppression_test. > > BUG=webrtc:5949 > > Committed: https://crrev.com/538b5606a3fb6310aab7a7e747aee16eac885f02 > Cr-Commit-Position: refs/heads/master@{#13890} TBR=kjellander@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 2 chunks +0 lines, -66 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sakal
Created Revert of GN build rules for four audio processing test executables
4 years, 4 months ago (2016-08-24 12:04:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2274813004/1
4 years, 4 months ago (2016-08-24 12:04:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 12:04:26 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 12:04:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98468bb456ac950b3fc2f1056c280ef73aacf301
Cr-Commit-Position: refs/heads/master@{#13891}

Powered by Google App Engine
This is Rietveld 408576698