Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/audio_device/BUILD.gn

Issue 2274713005: GN: Fix Windows Clang errors (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: It works! Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gyp_flag_compare.py ('K') | « webrtc/media/BUILD.gn ('k') | webrtc/modules/video_capture/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_device/BUILD.gn
diff --git a/webrtc/modules/audio_device/BUILD.gn b/webrtc/modules/audio_device/BUILD.gn
index 3f74ff68beda7a24309179579bab5282c3c14cbc..81242105ac43997eb5c0e14cfd2574a5a6518b71 100644
--- a/webrtc/modules/audio_device/BUILD.gn
+++ b/webrtc/modules/audio_device/BUILD.gn
@@ -193,6 +193,23 @@ source_set("audio_device") {
"msdmo.lib",
]
}
+ if (is_win && is_clang) {
+ cflags += [
+ # Disable warnings failing when compiling with Clang on Windows.
+ # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
+ "-Wno-bool-conversion",
+ "-Wno-delete-non-virtual-dtor",
+ "-Wno-logical-op-parentheses",
+ "-Wno-microsoft-extra-qualification",
+ "-Wno-microsoft-goto",
+ "-Wno-missing-braces",
+ "-Wno-parentheses-equality",
+ "-Wno-reorder",
+ "-Wno-shift-overflow",
+ "-Wno-tautological-compare",
+ "-Wno-unused-private-field",
+ ]
+ }
}
} else {
defines = [ "WEBRTC_DUMMY_AUDIO_BUILD" ]
« tools/gyp_flag_compare.py ('K') | « webrtc/media/BUILD.gn ('k') | webrtc/modules/video_capture/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698