Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/examples/BUILD.gn

Issue 2274713005: GN: Fix Windows Clang errors (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: It works! Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gyp_flag_compare.py ('K') | « webrtc/build/mb_config.pyl ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/examples/BUILD.gn
diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn
index e1fce2c521802bea1c5a5740669f48b4a5b0f96e..8b1f1877642d4acf2378f09e985a350aa7c4a6d7 100644
--- a/webrtc/examples/BUILD.gn
+++ b/webrtc/examples/BUILD.gn
@@ -415,6 +415,14 @@ if (is_linux || is_win) {
cflags = [ "/wd4245" ]
configs += [ "//build/config/win:windowed" ]
}
+ if (is_win && is_clang) {
+ cflags = [
+ # Disable warnings failing when compiling with Clang on Windows.
+ # https://bugs.chromium.org/p/webrtc/issues/detail?id=5366
+ "-Wno-reorder",
+ "-Wno-unused-function",
+ ]
+ }
if (is_linux) {
sources += [
"peerconnection/client/linux/main.cc",
« tools/gyp_flag_compare.py ('K') | « webrtc/build/mb_config.pyl ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698