Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2274713003: MB: Flip Mac bots to GN by default. (Closed)

Created:
4 years, 4 months ago by kjellander_webrtc
Modified:
4 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

MB: Flip Mac bots to GN by default. Change the previous GN configs to build GYP instead (since we'll keep GYP around for a while) but exclude tests and examples for that config, since we'll only support the production code for GYP. Add new configs for upcoming rename of those bots to GYP instead of GN. BUG=webrtc:5949 NOTRY=True Committed: https://crrev.com/f02207dde99132807f775fba1624a3a9c96e0e76 Cr-Commit-Position: refs/heads/master@{#13900}

Patch Set 1 #

Patch Set 2 : Exclude tests and examples #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M webrtc/build/mb_config.pyl View 1 5 chunks +34 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
Should be ready to go like this, right?
4 years, 4 months ago (2016-08-24 15:00:58 UTC) #3
ehmaldonado_webrtc
On 2016/08/24 15:00:58, kjellander_webrtc wrote: > Should be ready to go like this, right? LGTM
4 years, 4 months ago (2016-08-24 15:46:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2274713003/20001
4 years, 4 months ago (2016-08-24 15:59:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-24 16:40:05 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:40:11 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f02207dde99132807f775fba1624a3a9c96e0e76
Cr-Commit-Position: refs/heads/master@{#13900}

Powered by Google App Engine
This is Rietveld 408576698